Uh oh!
There was an error while loading. Please reload this page.
[Paddle] Some refactor and optimization on fused attention - #411
Conversation
Wong4j
commented
Aug 31, 2023
@jeng1220 Please take a look. |
Wong4j
commented
Sep 1, 2023
This PR will have some conflicts with PR#410. |
Wong4j
commented
Sep 1, 2023
@jeng1220
|
mingxu1067
commented
Sep 1, 2023
/te-ci |
a57d69d to
f3a2d73CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
zlsh80826
commented
Sep 4, 2023
/te-ci |
jeng1220
commented
Sep 4, 2023
LGTM. |
jeng1220
commented
Sep 5, 2023
The PR #412 needs to be merged first. |
Signed-off-by: Shijie Wang <jaywan@nvidia.com>
Signed-off-by: Shijie Wang <jaywan@nvidia.com>
Signed-off-by: Shijie Wang <jaywan@nvidia.com>
Signed-off-by: Shijie Wang <jaywan@nvidia.com>
Signed-off-by: Shijie Wang <jaywan@nvidia.com>
Signed-off-by: Shijie Wang <jaywan@nvidia.com>
3ab89fe to
646a1c5Comparemingxu1067
commented
Sep 7, 2023
/te-ci |
jeng1220
commented
Sep 12, 2023
There are some UT failures but they are not related to this PR:
Please review and merge the code if everything looks good. |
It seems that the new #403 changes the order of output dimensions of fused attention. - # output: [b, s, h]+ # output: [s, b, h]It will take some time to study how to integrate it into TE/Paddle. |
timmoon10
commented
Sep 26, 2023
That comment was incorrect, attention has already been using TransformerEngine/transformer_engine/paddle/layer/attention.py Lines 341 to 343 in 3f64de4 Could we do something similar for the TE backend? |
Thank you @timmoon10 . I also noticed TE-PyT use |
timmoon10
commented
Sep 30, 2023
/te-ci |
Signed-off-by: Tim Moon <tmoon@nvidia.com>
/te-ci Edit: Having trouble launching the job. See pipeline 10073671. |
mask->actual seqlens->cu seqlens.fused_attention_backendcheck in python code.