Skip to content

Change scaling factor from E8M0 to E8M23 - #427

Merged
ksivaman merged 4 commits into
NVIDIA:mainfrom
ksivaman:update_scaling_factor_calculation_method
Sep 23, 2023
Merged

Change scaling factor from E8M0 to E8M23#427
ksivaman merged 4 commits into
NVIDIA:mainfrom
ksivaman:update_scaling_factor_calculation_method

Conversation

@ksivaman

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
@NVIDIANVIDIA deleted a comment from nouizSep 8, 2023
@ksivaman

Copy link
Copy Markdown
MemberAuthor

/te-ci

Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
@ksivaman
ksivamanforce-pushed the update_scaling_factor_calculation_method branch from 59a6b96 to eacb28fCompareSeptember 21, 2023 22:14
Comment threadtransformer_engine/jax/fp8.py Outdated
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
@ksivaman

Copy link
Copy Markdown
MemberAuthor

/te-ci

@ksivaman
ksivaman merged commit 2da34d4 into NVIDIA:mainSep 23, 2023
ptrendx pushed a commit that referenced this pull request Oct 2, 2023
* Change scaling factor from E8M0 to E8M23
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
* fix formula
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
---------
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Comment threadtransformer_engine/pytorch/fp8.py
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ksivaman@ptrendx@jiecaoyu