Uh oh!
There was an error while loading. Please reload this page.
[PyTorch] Linear and LayerNormLinear bug fix for excess weight and bias buffers - #570
Merged
Merged
Conversation
…of init when there is no parameter split Signed-off-by: Alp Dener <adener@nvidia.com>
denera
commented
Dec 15, 2023
CollaboratorAuthor
/te-ci pytorch |
Signed-off-by: Alp Dener <adener@nvidia.com>
Signed-off-by: Alp Dener <adener@nvidia.com>
denera
commented
Dec 17, 2023
CollaboratorAuthor
/te-ci pytorch |
Quentin-Anthony pushed a commit
to EleutherAI/TransformerEngine
that referenced
this pull request
Jan 4, 2024
…as buffers (NVIDIA#570) * Linear and LayerNormLinear weight and bias buffer cleanup at the end of init when there is no parameter split Signed-off-by: Alp Dener <adener@nvidia.com> * fixed typo in tensor name Signed-off-by: Alp Dener <adener@nvidia.com> * fixed typo in tensor name Signed-off-by: Alp Dener <adener@nvidia.com> --------- Signed-off-by: Alp Dener <adener@nvidia.com> Signed-off-by: Quentin Anthony <qganthony@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear and LayerNormLinear initialization leaves behind unused copies of the weight and bias tensors when there is no parameter split. This PR removes these buffers at the end of the initialization.