Uh oh!
There was an error while loading. Please reload this page.
Fixing potential integer overflow on sequence counter - #729
Merged
Conversation
shamispforce-pushed
the
topic/overflow-fix
branch
4 times, most recently
from
March 23, 2024 05:04
d17dc7b to
f346513CompareCurrent implementation may potential cause hangs or data corruption Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com>
shamispforce-pushed
the
topic/overflow-fix
branch
from
March 25, 2024 23:14
f346513 to
19dc34bCompare| } | ||
| // Return true if producer > consumer, otherwise false while preventing integer overflow | ||
| // If we expect that produce will be 2B+ messages behind consumer |
Addressing reviewers comments Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com>
ksivaman
commented
Apr 3, 2024
Member
/te-ci pytorch |
ksivaman
approved these changes
Apr 4, 2024
ksivaman
left a comment
Member
There was a problem hiding this comment.
Got the greenlight from Anton.
shamisp added a commit
to shamisp/TransformerEngine
that referenced
this pull request
Apr 4, 2024
* Fixing potential integer overflow on sequence counter Current implementation may potential cause hangs or data corruption Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> * Fixing typo in comments Addressing reviewers comments Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> --------- Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
shamisp added a commit
to shamisp/TransformerEngine
that referenced
this pull request
Apr 5, 2024
* Fixing potential integer overflow on sequence counter Current implementation may potential cause hangs or data corruption Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> * Fixing typo in comments Addressing reviewers comments Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> --------- Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
pggPL pushed a commit
to pggPL/TransformerEngine
that referenced
this pull request
May 23, 2024
* Fixing potential integer overflow on sequence counter Current implementation may potential cause hangs or data corruption Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> * Fixing typo in comments Addressing reviewers comments Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> --------- Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com> Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation may potential cause hangs or data corruption