Uh oh!
There was an error while loading. Please reload this page.
[JAX] Fixing CI failure due to incorrect use of static_argnums in jax.jit - #785
Merged
Merged
Conversation
…warning filtering for pytest Signed-off-by: Alp Dener <adener@nvidia.com>
deneraforce-pushed
the
te-jax-single-gpu-encoder-test-fix
branch
from
April 16, 2024 16:48
960a1cc to
5a78a4dComparedenera
commented
Apr 16, 2024
CollaboratorAuthor
/te-ci jax |
nouiz
approved these changes
Apr 16, 2024
nouiz
left a comment
Collaborator
There was a problem hiding this comment.
Not sure if 2 PRs would have been better. No strong opinion here.
Collaborator
Should we fix test_single_gpu_mnist.py#L77 as well? It is the same error I found in other CI pipelines. |
Signed-off-by: Alp Dener <adener@nvidia.com>
Signed-off-by: Alp Dener <adener@nvidia.com>
denera
commented
Apr 16, 2024
CollaboratorAuthor
/te-ci jax |
zlsh80826
approved these changes
Apr 17, 2024
Signed-off-by: Alp Dener <adener@nvidia.com>
denera
commented
Apr 17, 2024
CollaboratorAuthor
/te-ci jax |
timmoon10 pushed a commit
to timmoon10/TransformerEngine
that referenced
this pull request
Apr 22, 2024
…ax.jit (NVIDIA#785) * fixed static argnums for jax.jit in single gpu encoder test, changed warning filtering for pytest Signed-off-by: Alp Dener <adener@nvidia.com> * propagating the fix to the JAX mnist example Signed-off-by: Alp Dener <adener@nvidia.com> * fixed missing space ibetween flags i QAA scripts Signed-off-by: Alp Dener <adener@nvidia.com> * added TE warnings into the ignore list Signed-off-by: Alp Dener <adener@nvidia.com> --------- Signed-off-by: Alp Dener <adener@nvidia.com> Signed-off-by: Tim Moon <tmoon@nvidia.com>
ksivaman pushed a commit
that referenced
this pull request
Apr 24, 2024
* [JAX] Fixing CI failure due to incorrect use of `static_argnums` in jax.jit (#785) * fixed static argnums for jax.jit in single gpu encoder test, changed warning filtering for pytest Signed-off-by: Alp Dener <adener@nvidia.com> * propagating the fix to the JAX mnist example Signed-off-by: Alp Dener <adener@nvidia.com> * fixed missing space ibetween flags i QAA scripts Signed-off-by: Alp Dener <adener@nvidia.com> * added TE warnings into the ignore list Signed-off-by: Alp Dener <adener@nvidia.com> --------- Signed-off-by: Alp Dener <adener@nvidia.com> Signed-off-by: Tim Moon <tmoon@nvidia.com> * [JAX] Allow multi-dims for dgamma and dbeta in LN descriptor. (#780) * Allow multi-dims for dgamma and dbeta in LN descriptor. Signed-off-by: Ming Huang <mingh@nvidia.com> * Fix the jit error in examples/jax Signed-off-by: Ming Huang <mingh@nvidia.com> --------- Signed-off-by: Ming Huang <mingh@nvidia.com> Signed-off-by: Tim Moon <tmoon@nvidia.com> --------- Signed-off-by: Alp Dener <adener@nvidia.com> Signed-off-by: Tim Moon <tmoon@nvidia.com> Signed-off-by: Ming Huang <mingh@nvidia.com> Co-authored-by: Alp Dener <adener@nvidia.com> Co-authored-by: Ming-Xu Huang <mingh@nvidia.com>
pggPL pushed a commit
to pggPL/TransformerEngine
that referenced
this pull request
May 23, 2024
…ax.jit (NVIDIA#785) * fixed static argnums for jax.jit in single gpu encoder test, changed warning filtering for pytest Signed-off-by: Alp Dener <adener@nvidia.com> * propagating the fix to the JAX mnist example Signed-off-by: Alp Dener <adener@nvidia.com> * fixed missing space ibetween flags i QAA scripts Signed-off-by: Alp Dener <adener@nvidia.com> * added TE warnings into the ignore list Signed-off-by: Alp Dener <adener@nvidia.com> --------- Signed-off-by: Alp Dener <adener@nvidia.com> Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the incorrect syntax for
static_argnumsin the single-GPU encoder example.JAX has apparently been raising a warning about this for close to 2 years that went unnoticed on our end because we run TE/JAX CI with a global warning ignore:
pytest -WignoreThis PR replaces
-Wignorewith a limited set of filtered warnings defined undertests/jax/pytest.ini. The list of warnings here are based on JAX's own pytest ignores. Any warnings in the CI not covered by this list and need to be filtered should be added to this file moving forward.