Uh oh!
There was an error while loading. Please reload this page.
[PyTorch] Fix for type checking failure on custom callables - #790
Merged
Conversation
…dules in custom callables Signed-off-by: Alp Dener <adener@nvidia.com>
denera
commented
Apr 17, 2024
CollaboratorAuthor
/te-ci pytorch |
pggPL pushed a commit
to pggPL/TransformerEngine
that referenced
this pull request
May 23, 2024
fix type checking in checkpointing to assume that there must be TE modules in custom callables Signed-off-by: Alp Dener <adener@nvidia.com> Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for TE checkpoint incorrectly passing custom classes/callables to the native PyTorch checkpoint.