Uh oh!
There was an error while loading. Please reload this page.
[PyTorch] Fix linter warnings from unused args - #816
Merged
Conversation
Signed-off-by: Tim Moon <tmoon@nvidia.com>
timmoon10
commented
Apr 26, 2024
MemberAuthor
/te-ci pytorch |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com> Signed-off-by: Tim Moon <4406448+timmoon10@users.noreply.github.com>
phu0ngng pushed a commit
to phu0ngng/TransformerEngine
that referenced
this pull request
May 3, 2024
* Fix linter warnings from unused args Signed-off-by: Tim Moon <tmoon@nvidia.com> * Update .gitignore Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com> Signed-off-by: Tim Moon <4406448+timmoon10@users.noreply.github.com> --------- Signed-off-by: Tim Moon <tmoon@nvidia.com> Signed-off-by: Tim Moon <4406448+timmoon10@users.noreply.github.com> Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
pggPL pushed a commit
to pggPL/TransformerEngine
that referenced
this pull request
May 23, 2024
* Fix linter warnings from unused args Signed-off-by: Tim Moon <tmoon@nvidia.com> * Update .gitignore Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com> Signed-off-by: Tim Moon <4406448+timmoon10@users.noreply.github.com> --------- Signed-off-by: Tim Moon <tmoon@nvidia.com> Signed-off-by: Tim Moon <4406448+timmoon10@users.noreply.github.com> Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com> Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're seeing Pylint failures in the nightly CI because we are defining some PyTorch autograd functions that don't access the autograd context. This PR silences those warnings by renaming the args with a leading underscore.