Skip to content

Find CXX component for MPI, fortran and C are not needed - #828

Closed
aurianer wants to merge 1 commit into
NVIDIA:mainfrom
aurianer:mpi_find_only_cxx_component
Closed

Find CXX component for MPI, fortran and C are not needed#828
aurianer wants to merge 1 commit into
NVIDIA:mainfrom
aurianer:mpi_find_only_cxx_component

Conversation

@aurianer

@aurianeraurianer commented May 1, 2024

Copy link
Copy Markdown
Contributor

Description

The default find_package is searching for all components. From the CMakeLists.txt I modified, you are linking only against MPI::MPI_CXX target. It is unnecessary to find the other C and Fortran mpi components.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Cleanup

Signed-off-by: aurianer <aurianer@cscs.ch>
@aurianer
aurianerforce-pushed the mpi_find_only_cxx_component branch from 6777a2f to d196af8CompareMay 1, 2024 16:22

@timmoon10timmoon10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will be superceded by #760, but we should make sure to incorporate this PR at https://github.com/NVIDIA/TransformerEngine/pull/760/files#r1586537899.

@aurianer

Copy link
Copy Markdown
ContributorAuthor

Once the change is backported there, feel free to close this PR :)

@aurianer

Copy link
Copy Markdown
ContributorAuthor

Another way might be to merge this PR and do a rebase on main, I don't think this would create any conflicts :)

@aurianeraurianer closed this Jun 3, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@aurianer@timmoon10