Uh oh!
There was an error while loading. Please reload this page.
Added comments about Llama3 weights to Llama tutorial - #830
Merged
Conversation
pggPLforce-pushed
the
Llama3-tutorial
branch
4 times, most recently
from
May 15, 2024 18:36
4272e91 to
2a42afcCompareSigned-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
ptrendx
commented
May 21, 2024
Member
@sudhakarsingh27 Please review. |
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Signed-off-by: Sudhakar Singh <sudhakars@nvidia.com>
Signed-off-by: Sudhakar Singh <sudhakars@nvidia.com>
…rEngine into Llama3-tutorial
Signed-off-by: Sudhakar Singh <sudhakars@nvidia.com>
sudhakarsingh27
commented
May 31, 2024
Member
@ptrendx I've reviewed and added the necessary changes. Could you pls give it one look? |
Signed-off-by: Sudhakar Singh <sudhakars@nvidia.com>
…rEngine into Llama3-tutorial
ptrendx
approved these changes
Jun 1, 2024
ptrendx pushed a commit
that referenced
this pull request
Jun 1, 2024
* Llama 3 update Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com> * Times update Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com> * Times update Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com> * utils.py fix Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com> * utils.py fix Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com> * utils.py fix Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com> * update te llama tutorial to allow running with llama 3 weights Signed-off-by: Sudhakar Singh <sudhakars@nvidia.com> * small fixes Signed-off-by: Sudhakar Singh <sudhakars@nvidia.com> * small fix Signed-off-by: Sudhakar Singh <sudhakars@nvidia.com> * small fix Signed-off-by: Sudhakar Singh <sudhakars@nvidia.com> * add llama 3 vs llama 2 distinctions Signed-off-by: Sudhakar Singh <sudhakars@nvidia.com> * paraphrasing and corrected facts Signed-off-by: Sudhakar Singh <sudhakars@nvidia.com> * fix Signed-off-by: Sudhakar Singh <sudhakars@nvidia.com> * fix Signed-off-by: Sudhakar Singh <sudhakars@nvidia.com> --------- Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com> Signed-off-by: Sudhakar Singh <sudhakars@nvidia.com> Co-authored-by: Pawel Gadzinski <pgadzinski@nvidia.com> Co-authored-by: Sudhakar Singh <sudhakars@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Meta released LLama 3 model in April. We have tutorial for Llama 2. It turned out that it works with Llama 3. I changed comments within tutorial. They inform that the code can be run with Llama 3 weights as well. I did not change the benchmark time(it's only Llama 2).
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: