Skip to content

Move from Sphinx Autodoc to sphinx-autoapi - #92

Merged
ksivaman merged 7 commits into
NVIDIA:mainfrom
ptrendx:pr_autoapi
Mar 11, 2023
Merged

Move from Sphinx Autodoc to sphinx-autoapi#92
ksivaman merged 7 commits into
NVIDIA:mainfrom
ptrendx:pr_autoapi

Conversation

@ptrendx

@ptrendxptrendx commented Mar 10, 2023

Copy link
Copy Markdown
Member

As we move forward with the support for multiple frameworks, the behavior of autodoc to import everything becomes an issue - we would need to have a container with all frameworks installed, which is going to be an issue with handling all of the dependencies. AutoAPI does not need to import the module to generate documentation, which is much better in this case.

Also add GitHub action to build the documentation.

@ptrendx
Change from AutoDoc to AutoAPI
010c363
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Fixes
191afc8
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
@ptrendx
WAR for the wrong autosummary generation
264de00
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
@ptrendx
Change common to be in line with pytorch API docs
ee1326a
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Add GitHub Action to build docs
ae42a42
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Fix
260cd3e
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Trying to fix the versions
6037e25
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
ptrendx marked this pull request as ready for review March 10, 2023 23:14
@ptrendx

ptrendx commented Mar 10, 2023

Copy link
Copy Markdown
MemberAuthor

/te-ci

timmoon10
timmoon10 approved these changes Mar 11, 2023
View reviewed changes

@timmoon10timmoon10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The generated docs look sensible.

ksivaman
ksivaman reviewed Mar 11, 2023
View reviewed changes
Comment threadtransformer_engine/pytorch/transformer.py
ksivaman
ksivaman approved these changes Mar 11, 2023
View reviewed changes

@ksivamanksivaman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksivaman
ksivaman merged commit c9245c0 into NVIDIA:mainMar 11, 2023
cyanguwa pushed a commit to cyanguwa/TransformerEngine that referenced this pull request Mar 31, 2023
@ptrendx@cyanguwa
Move from Sphinx Autodoc to sphinx-autoapi (NVIDIA#92)
0cb784a
* Change from AutoDoc to AutoAPI
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fixes
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* WAR for the wrong autosummary generation
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* Change common to be in line with pytorch API docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Add GitHub Action to build docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fix
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Trying to fix the versions
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
---------
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
Signed-off-by: Charlene Yang <charleney@nvidia.com>
cyanguwa pushed a commit to cyanguwa/TransformerEngine that referenced this pull request Apr 1, 2023
@ptrendx@cyanguwa
Move from Sphinx Autodoc to sphinx-autoapi (NVIDIA#92)
9dac379
* Change from AutoDoc to AutoAPI
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fixes
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* WAR for the wrong autosummary generation
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* Change common to be in line with pytorch API docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Add GitHub Action to build docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fix
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Trying to fix the versions
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
---------
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
Signed-off-by: Charlene Yang <charleney@nvidia.com>
zhiyu-deep pushed a commit to zhiyu-deep/TransformerEngine that referenced this pull request Sep 3, 2024
@Anerudhan
cudnn FE 1.6.0
924307e
New API (NVIDIA#92)
- Graph Slice Operation: Introduced the graph.slice operation for slicing input tensors. Refer to docs/operations/Slice.md for detailed documentation and samples/cpp/misc/slice.cpp for a C++ sample. Pybinds for this operation have also been added.
- SM Carveout Feature: Added the set_sm_count(int32_t type) graph property to support the SM Carveout feature introduced in Ampere and Hopper GPUs. Engines that do not support SM_COUNT will return NOT_SUPPORTED.
Bug Fixes
- Convolution Mode Attribute: Added the missing set_convolution_mode attribute to convolution attributes in forward propagation (fprop), data gradient (dgrad), and weight gradient (wgrad). Previously, this was hardcoded to CUDNN_CROSS_CORRELATION in the 1.x API.
- SDPA FP8 Backward Node: Fixed an issue with the deserialization of the sdpa_fp8_backward node.
Enhancements
- Graph Execution Overhead: Reduced the overhead of graph.execute() by optimizing sub-node tree traversal, collected UIDs, workspace modifications, and workspace size.
- Graph Validation Performance: Significantly improved (~10x) the performance of graph.validate() by deferring graph expansion to a later stage (build_operation_graph).
- Optional Running Stats for BatchNorm: Made the running statistics for the batch normalization operation optional, supported by cuDNN backend version 9.3.0 and later.
- Shape and Stride Inferencing: Enhanced shape and stride inferencing to preserve the stride order of the input.
- Diagnostic Error Message: Added a diagnostic error message to create_execution_plans if called without the preceding build_operation_graph.
- JSON Schema and Deserialization: Improved the JSON schema and deserialization logic with additional checks.
- Logging Overhead: Reduced logging overhead, resulting in faster graph.build() calls.
- CMake Integration: Replaced CMAKE_SOURCE_DIR with PROJECT_SOURCE_DIR in CMake files for better integration. See the relevant pull request for more details.
Samples
- Jupyter Notebooks: Added Jupyter notebooks for RMSNorm, InstanceNorm, and LayerNorm. Refer to the samples/python folder for more information.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timmoon10timmoon10timmoon10 approved these changes
@ksivamanksivamanksivaman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ptrendx@timmoon10@ksivaman
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Move from Sphinx Autodoc to sphinx-autoapi by ptrendx · Pull Request #92 · NVIDIA/TransformerEngine · GitHub
Skip to content
Move from Sphinx Autodoc to sphinx-autoapi - #92
Merged
ksivaman merged 7 commits into
NVIDIA:mainfrom 
ptrendx:pr_autoapi
Mar 11, 2023
Merged
Move from Sphinx Autodoc to sphinx-autoapi#92
ksivaman merged 7 commits into
NVIDIA:mainfrom 
ptrendx:pr_autoapi
Conversation
@ptrendx
@ptrendxptrendx
commented
Mar 10, 2023

Copy link


Copy Markdown

Member
As we move forward with the support for multiple frameworks, the behavior of autodoc to import everything becomes an issue - we would need to have a container with all frameworks installed, which is going to be an issue with handling all of the dependencies. AutoAPI does not need to import the module to generate documentation, which is much better in this case.
Also add GitHub action to build the documentation.
@ptrendx
Change from AutoDoc to AutoAPI
010c363
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Fixes
191afc8
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
@ptrendx
WAR for the wrong autosummary generation
264de00
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
@ptrendx
Change common to be in line with pytorch API docs
ee1326a
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Add GitHub Action to build docs
ae42a42
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Fix
260cd3e
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Trying to fix the versions
6037e25
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
ptrendx
marked this pull request as ready for review
March 10, 2023 23:14
@ptrendx
ptrendx
commented
Mar 10, 2023

Copy link


Copy Markdown

MemberAuthor
/te-ci
timmoon10
timmoon10
approved these changes
Mar 11, 2023
View reviewed changes
@timmoon10timmoon10
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The generated docs look sensible.
ksivaman
ksivaman
reviewed
Mar 11, 2023
View reviewed changes
Comment threadtransformer_engine/pytorch/transformer.py
ksivaman
ksivaman
approved these changes
Mar 11, 2023
View reviewed changes
@ksivamanksivaman
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ksivaman
ksivaman
merged commit c9245c0
into
NVIDIA:mainMar 11, 2023
cyanguwa pushed a commit
to cyanguwa/TransformerEngine
that referenced
this pull request
Mar 31, 2023
@ptrendx@cyanguwa
Move from Sphinx Autodoc to sphinx-autoapi (NVIDIA#92)
0cb784a
* Change from AutoDoc to AutoAPI
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fixes
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* WAR for the wrong autosummary generation
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* Change common to be in line with pytorch API docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Add GitHub Action to build docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fix
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Trying to fix the versions
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
---------
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
Signed-off-by: Charlene Yang <charleney@nvidia.com>
cyanguwa pushed a commit
to cyanguwa/TransformerEngine
that referenced
this pull request
Apr 1, 2023
@ptrendx@cyanguwa
Move from Sphinx Autodoc to sphinx-autoapi (NVIDIA#92)
9dac379
* Change from AutoDoc to AutoAPI
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fixes
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* WAR for the wrong autosummary generation
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* Change common to be in line with pytorch API docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Add GitHub Action to build docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fix
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Trying to fix the versions
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
---------
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
Signed-off-by: Charlene Yang <charleney@nvidia.com>
zhiyu-deep pushed a commit
to zhiyu-deep/TransformerEngine
that referenced
this pull request
Sep 3, 2024
@Anerudhan
cudnn FE 1.6.0
924307e
New API (NVIDIA#92)
- Graph Slice Operation: Introduced the graph.slice operation for slicing input tensors. Refer to docs/operations/Slice.md for detailed documentation and samples/cpp/misc/slice.cpp for a C++ sample. Pybinds for this operation have also been added.
- SM Carveout Feature: Added the set_sm_count(int32_t type) graph property to support the SM Carveout feature introduced in Ampere and Hopper GPUs. Engines that do not support SM_COUNT will return NOT_SUPPORTED.
Bug Fixes
- Convolution Mode Attribute: Added the missing set_convolution_mode attribute to convolution attributes in forward propagation (fprop), data gradient (dgrad), and weight gradient (wgrad). Previously, this was hardcoded to CUDNN_CROSS_CORRELATION in the 1.x API.
- SDPA FP8 Backward Node: Fixed an issue with the deserialization of the sdpa_fp8_backward node.
Enhancements
- Graph Execution Overhead: Reduced the overhead of graph.execute() by optimizing sub-node tree traversal, collected UIDs, workspace modifications, and workspace size.
- Graph Validation Performance: Significantly improved (~10x) the performance of graph.validate() by deferring graph expansion to a later stage (build_operation_graph).
- Optional Running Stats for BatchNorm: Made the running statistics for the batch normalization operation optional, supported by cuDNN backend version 9.3.0 and later.
- Shape and Stride Inferencing: Enhanced shape and stride inferencing to preserve the stride order of the input.
- Diagnostic Error Message: Added a diagnostic error message to create_execution_plans if called without the preceding build_operation_graph.
- JSON Schema and Deserialization: Improved the JSON schema and deserialization logic with additional checks.
- Logging Overhead: Reduced logging overhead, resulting in faster graph.build() calls.
- CMake Integration: Replaced CMAKE_SOURCE_DIR with PROJECT_SOURCE_DIR in CMake files for better integration. See the relevant pull request for more details.
Samples
- Jupyter Notebooks: Added Jupyter notebooks for RMSNorm, InstanceNorm, and LayerNorm. Refer to the samples/python folder for more information.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@timmoon10timmoon10timmoon10 approved these changes
@ksivamanksivamanksivaman approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ptrendx@timmoon10@ksivaman

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Move from Sphinx Autodoc to sphinx-autoapi by ptrendx · Pull Request #92 · NVIDIA/TransformerEngine · GitHub
Skip to content
Move from Sphinx Autodoc to sphinx-autoapi - #92
Merged
ksivaman merged 7 commits into
NVIDIA:mainfrom 
ptrendx:pr_autoapi
Mar 11, 2023
Merged
Move from Sphinx Autodoc to sphinx-autoapi#92
ksivaman merged 7 commits into
NVIDIA:mainfrom 
ptrendx:pr_autoapi
Conversation
@ptrendx
@ptrendxptrendx
commented
Mar 10, 2023

Copy link


Copy Markdown

Member
As we move forward with the support for multiple frameworks, the behavior of autodoc to import everything becomes an issue - we would need to have a container with all frameworks installed, which is going to be an issue with handling all of the dependencies. AutoAPI does not need to import the module to generate documentation, which is much better in this case.
Also add GitHub action to build the documentation.
@ptrendx
Change from AutoDoc to AutoAPI
010c363
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Fixes
191afc8
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
@ptrendx
WAR for the wrong autosummary generation
264de00
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
@ptrendx
Change common to be in line with pytorch API docs
ee1326a
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Add GitHub Action to build docs
ae42a42
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Fix
260cd3e
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Trying to fix the versions
6037e25
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
ptrendx
marked this pull request as ready for review
March 10, 2023 23:14
@ptrendx
ptrendx
commented
Mar 10, 2023

Copy link


Copy Markdown

MemberAuthor
/te-ci
timmoon10
timmoon10
approved these changes
Mar 11, 2023
View reviewed changes
@timmoon10timmoon10
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The generated docs look sensible.
ksivaman
ksivaman
reviewed
Mar 11, 2023
View reviewed changes
Comment threadtransformer_engine/pytorch/transformer.py
ksivaman
ksivaman
approved these changes
Mar 11, 2023
View reviewed changes
@ksivamanksivaman
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ksivaman
ksivaman
merged commit c9245c0
into
NVIDIA:mainMar 11, 2023
cyanguwa pushed a commit
to cyanguwa/TransformerEngine
that referenced
this pull request
Mar 31, 2023
@ptrendx@cyanguwa
Move from Sphinx Autodoc to sphinx-autoapi (NVIDIA#92)
0cb784a
* Change from AutoDoc to AutoAPI
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fixes
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* WAR for the wrong autosummary generation
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* Change common to be in line with pytorch API docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Add GitHub Action to build docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fix
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Trying to fix the versions
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
---------
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
Signed-off-by: Charlene Yang <charleney@nvidia.com>
cyanguwa pushed a commit
to cyanguwa/TransformerEngine
that referenced
this pull request
Apr 1, 2023
@ptrendx@cyanguwa
Move from Sphinx Autodoc to sphinx-autoapi (NVIDIA#92)
9dac379
* Change from AutoDoc to AutoAPI
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fixes
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* WAR for the wrong autosummary generation
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* Change common to be in line with pytorch API docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Add GitHub Action to build docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fix
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Trying to fix the versions
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
---------
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
Signed-off-by: Charlene Yang <charleney@nvidia.com>
zhiyu-deep pushed a commit
to zhiyu-deep/TransformerEngine
that referenced
this pull request
Sep 3, 2024
@Anerudhan
cudnn FE 1.6.0
924307e
New API (NVIDIA#92)
- Graph Slice Operation: Introduced the graph.slice operation for slicing input tensors. Refer to docs/operations/Slice.md for detailed documentation and samples/cpp/misc/slice.cpp for a C++ sample. Pybinds for this operation have also been added.
- SM Carveout Feature: Added the set_sm_count(int32_t type) graph property to support the SM Carveout feature introduced in Ampere and Hopper GPUs. Engines that do not support SM_COUNT will return NOT_SUPPORTED.
Bug Fixes
- Convolution Mode Attribute: Added the missing set_convolution_mode attribute to convolution attributes in forward propagation (fprop), data gradient (dgrad), and weight gradient (wgrad). Previously, this was hardcoded to CUDNN_CROSS_CORRELATION in the 1.x API.
- SDPA FP8 Backward Node: Fixed an issue with the deserialization of the sdpa_fp8_backward node.
Enhancements
- Graph Execution Overhead: Reduced the overhead of graph.execute() by optimizing sub-node tree traversal, collected UIDs, workspace modifications, and workspace size.
- Graph Validation Performance: Significantly improved (~10x) the performance of graph.validate() by deferring graph expansion to a later stage (build_operation_graph).
- Optional Running Stats for BatchNorm: Made the running statistics for the batch normalization operation optional, supported by cuDNN backend version 9.3.0 and later.
- Shape and Stride Inferencing: Enhanced shape and stride inferencing to preserve the stride order of the input.
- Diagnostic Error Message: Added a diagnostic error message to create_execution_plans if called without the preceding build_operation_graph.
- JSON Schema and Deserialization: Improved the JSON schema and deserialization logic with additional checks.
- Logging Overhead: Reduced logging overhead, resulting in faster graph.build() calls.
- CMake Integration: Replaced CMAKE_SOURCE_DIR with PROJECT_SOURCE_DIR in CMake files for better integration. See the relevant pull request for more details.
Samples
- Jupyter Notebooks: Added Jupyter notebooks for RMSNorm, InstanceNorm, and LayerNorm. Refer to the samples/python folder for more information.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@timmoon10timmoon10timmoon10 approved these changes
@ksivamanksivamanksivaman approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ptrendx@timmoon10@ksivaman

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Move from Sphinx Autodoc to sphinx-autoapi by ptrendx · Pull Request #92 · NVIDIA/TransformerEngine · GitHub
Skip to content
Move from Sphinx Autodoc to sphinx-autoapi - #92
Merged
ksivaman merged 7 commits into
NVIDIA:mainfrom 
ptrendx:pr_autoapi
Mar 11, 2023
Merged
Move from Sphinx Autodoc to sphinx-autoapi#92
ksivaman merged 7 commits into
NVIDIA:mainfrom 
ptrendx:pr_autoapi
Conversation
@ptrendx
@ptrendxptrendx
commented
Mar 10, 2023

Copy link


Copy Markdown

Member
As we move forward with the support for multiple frameworks, the behavior of autodoc to import everything becomes an issue - we would need to have a container with all frameworks installed, which is going to be an issue with handling all of the dependencies. AutoAPI does not need to import the module to generate documentation, which is much better in this case.
Also add GitHub action to build the documentation.
@ptrendx
Change from AutoDoc to AutoAPI
010c363
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Fixes
191afc8
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
@ptrendx
WAR for the wrong autosummary generation
264de00
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
@ptrendx
Change common to be in line with pytorch API docs
ee1326a
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Add GitHub Action to build docs
ae42a42
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Fix
260cd3e
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Trying to fix the versions
6037e25
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
ptrendx
marked this pull request as ready for review
March 10, 2023 23:14
@ptrendx
ptrendx
commented
Mar 10, 2023

Copy link


Copy Markdown

MemberAuthor
/te-ci
timmoon10
timmoon10
approved these changes
Mar 11, 2023
View reviewed changes
@timmoon10timmoon10
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The generated docs look sensible.
ksivaman
ksivaman
reviewed
Mar 11, 2023
View reviewed changes
Comment threadtransformer_engine/pytorch/transformer.py
ksivaman
ksivaman
approved these changes
Mar 11, 2023
View reviewed changes
@ksivamanksivaman
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ksivaman
ksivaman
merged commit c9245c0
into
NVIDIA:mainMar 11, 2023
cyanguwa pushed a commit
to cyanguwa/TransformerEngine
that referenced
this pull request
Mar 31, 2023
@ptrendx@cyanguwa
Move from Sphinx Autodoc to sphinx-autoapi (NVIDIA#92)
0cb784a
* Change from AutoDoc to AutoAPI
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fixes
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* WAR for the wrong autosummary generation
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* Change common to be in line with pytorch API docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Add GitHub Action to build docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fix
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Trying to fix the versions
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
---------
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
Signed-off-by: Charlene Yang <charleney@nvidia.com>
cyanguwa pushed a commit
to cyanguwa/TransformerEngine
that referenced
this pull request
Apr 1, 2023
@ptrendx@cyanguwa
Move from Sphinx Autodoc to sphinx-autoapi (NVIDIA#92)
9dac379
* Change from AutoDoc to AutoAPI
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fixes
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* WAR for the wrong autosummary generation
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* Change common to be in line with pytorch API docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Add GitHub Action to build docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fix
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Trying to fix the versions
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
---------
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
Signed-off-by: Charlene Yang <charleney@nvidia.com>
zhiyu-deep pushed a commit
to zhiyu-deep/TransformerEngine
that referenced
this pull request
Sep 3, 2024
@Anerudhan
cudnn FE 1.6.0
924307e
New API (NVIDIA#92)
- Graph Slice Operation: Introduced the graph.slice operation for slicing input tensors. Refer to docs/operations/Slice.md for detailed documentation and samples/cpp/misc/slice.cpp for a C++ sample. Pybinds for this operation have also been added.
- SM Carveout Feature: Added the set_sm_count(int32_t type) graph property to support the SM Carveout feature introduced in Ampere and Hopper GPUs. Engines that do not support SM_COUNT will return NOT_SUPPORTED.
Bug Fixes
- Convolution Mode Attribute: Added the missing set_convolution_mode attribute to convolution attributes in forward propagation (fprop), data gradient (dgrad), and weight gradient (wgrad). Previously, this was hardcoded to CUDNN_CROSS_CORRELATION in the 1.x API.
- SDPA FP8 Backward Node: Fixed an issue with the deserialization of the sdpa_fp8_backward node.
Enhancements
- Graph Execution Overhead: Reduced the overhead of graph.execute() by optimizing sub-node tree traversal, collected UIDs, workspace modifications, and workspace size.
- Graph Validation Performance: Significantly improved (~10x) the performance of graph.validate() by deferring graph expansion to a later stage (build_operation_graph).
- Optional Running Stats for BatchNorm: Made the running statistics for the batch normalization operation optional, supported by cuDNN backend version 9.3.0 and later.
- Shape and Stride Inferencing: Enhanced shape and stride inferencing to preserve the stride order of the input.
- Diagnostic Error Message: Added a diagnostic error message to create_execution_plans if called without the preceding build_operation_graph.
- JSON Schema and Deserialization: Improved the JSON schema and deserialization logic with additional checks.
- Logging Overhead: Reduced logging overhead, resulting in faster graph.build() calls.
- CMake Integration: Replaced CMAKE_SOURCE_DIR with PROJECT_SOURCE_DIR in CMake files for better integration. See the relevant pull request for more details.
Samples
- Jupyter Notebooks: Added Jupyter notebooks for RMSNorm, InstanceNorm, and LayerNorm. Refer to the samples/python folder for more information.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@timmoon10timmoon10timmoon10 approved these changes
@ksivamanksivamanksivaman approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ptrendx@timmoon10@ksivaman

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Move from Sphinx Autodoc to sphinx-autoapi by ptrendx · Pull Request #92 · NVIDIA/TransformerEngine · GitHub
Skip to content
Move from Sphinx Autodoc to sphinx-autoapi - #92
Merged
ksivaman merged 7 commits into
NVIDIA:mainfrom 
ptrendx:pr_autoapi
Mar 11, 2023
Merged
Move from Sphinx Autodoc to sphinx-autoapi#92
ksivaman merged 7 commits into
NVIDIA:mainfrom 
ptrendx:pr_autoapi
Conversation
@ptrendx
@ptrendxptrendx
commented
Mar 10, 2023

Copy link


Copy Markdown

Member
As we move forward with the support for multiple frameworks, the behavior of autodoc to import everything becomes an issue - we would need to have a container with all frameworks installed, which is going to be an issue with handling all of the dependencies. AutoAPI does not need to import the module to generate documentation, which is much better in this case.
Also add GitHub action to build the documentation.
@ptrendx
Change from AutoDoc to AutoAPI
010c363
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Fixes
191afc8
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
@ptrendx
WAR for the wrong autosummary generation
264de00
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
@ptrendx
Change common to be in line with pytorch API docs
ee1326a
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Add GitHub Action to build docs
ae42a42
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Fix
260cd3e
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Trying to fix the versions
6037e25
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
ptrendx
marked this pull request as ready for review
March 10, 2023 23:14
@ptrendx
ptrendx
commented
Mar 10, 2023

Copy link


Copy Markdown

MemberAuthor
/te-ci
timmoon10
timmoon10
approved these changes
Mar 11, 2023
View reviewed changes
@timmoon10timmoon10
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The generated docs look sensible.
ksivaman
ksivaman
reviewed
Mar 11, 2023
View reviewed changes
Comment threadtransformer_engine/pytorch/transformer.py
ksivaman
ksivaman
approved these changes
Mar 11, 2023
View reviewed changes
@ksivamanksivaman
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ksivaman
ksivaman
merged commit c9245c0
into
NVIDIA:mainMar 11, 2023
cyanguwa pushed a commit
to cyanguwa/TransformerEngine
that referenced
this pull request
Mar 31, 2023
@ptrendx@cyanguwa
Move from Sphinx Autodoc to sphinx-autoapi (NVIDIA#92)
0cb784a
* Change from AutoDoc to AutoAPI
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fixes
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* WAR for the wrong autosummary generation
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* Change common to be in line with pytorch API docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Add GitHub Action to build docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fix
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Trying to fix the versions
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
---------
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
Signed-off-by: Charlene Yang <charleney@nvidia.com>
cyanguwa pushed a commit
to cyanguwa/TransformerEngine
that referenced
this pull request
Apr 1, 2023
@ptrendx@cyanguwa
Move from Sphinx Autodoc to sphinx-autoapi (NVIDIA#92)
9dac379
* Change from AutoDoc to AutoAPI
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fixes
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* WAR for the wrong autosummary generation
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* Change common to be in line with pytorch API docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Add GitHub Action to build docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fix
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Trying to fix the versions
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
---------
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
Signed-off-by: Charlene Yang <charleney@nvidia.com>
zhiyu-deep pushed a commit
to zhiyu-deep/TransformerEngine
that referenced
this pull request
Sep 3, 2024
@Anerudhan
cudnn FE 1.6.0
924307e
New API (NVIDIA#92)
- Graph Slice Operation: Introduced the graph.slice operation for slicing input tensors. Refer to docs/operations/Slice.md for detailed documentation and samples/cpp/misc/slice.cpp for a C++ sample. Pybinds for this operation have also been added.
- SM Carveout Feature: Added the set_sm_count(int32_t type) graph property to support the SM Carveout feature introduced in Ampere and Hopper GPUs. Engines that do not support SM_COUNT will return NOT_SUPPORTED.
Bug Fixes
- Convolution Mode Attribute: Added the missing set_convolution_mode attribute to convolution attributes in forward propagation (fprop), data gradient (dgrad), and weight gradient (wgrad). Previously, this was hardcoded to CUDNN_CROSS_CORRELATION in the 1.x API.
- SDPA FP8 Backward Node: Fixed an issue with the deserialization of the sdpa_fp8_backward node.
Enhancements
- Graph Execution Overhead: Reduced the overhead of graph.execute() by optimizing sub-node tree traversal, collected UIDs, workspace modifications, and workspace size.
- Graph Validation Performance: Significantly improved (~10x) the performance of graph.validate() by deferring graph expansion to a later stage (build_operation_graph).
- Optional Running Stats for BatchNorm: Made the running statistics for the batch normalization operation optional, supported by cuDNN backend version 9.3.0 and later.
- Shape and Stride Inferencing: Enhanced shape and stride inferencing to preserve the stride order of the input.
- Diagnostic Error Message: Added a diagnostic error message to create_execution_plans if called without the preceding build_operation_graph.
- JSON Schema and Deserialization: Improved the JSON schema and deserialization logic with additional checks.
- Logging Overhead: Reduced logging overhead, resulting in faster graph.build() calls.
- CMake Integration: Replaced CMAKE_SOURCE_DIR with PROJECT_SOURCE_DIR in CMake files for better integration. See the relevant pull request for more details.
Samples
- Jupyter Notebooks: Added Jupyter notebooks for RMSNorm, InstanceNorm, and LayerNorm. Refer to the samples/python folder for more information.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@timmoon10timmoon10timmoon10 approved these changes
@ksivamanksivamanksivaman approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ptrendx@timmoon10@ksivaman

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Move from Sphinx Autodoc to sphinx-autoapi by ptrendx · Pull Request #92 · NVIDIA/TransformerEngine · GitHub
Skip to content
Move from Sphinx Autodoc to sphinx-autoapi - #92
Merged
ksivaman merged 7 commits into
NVIDIA:mainfrom 
ptrendx:pr_autoapi
Mar 11, 2023
Merged
Move from Sphinx Autodoc to sphinx-autoapi#92
ksivaman merged 7 commits into
NVIDIA:mainfrom 
ptrendx:pr_autoapi
Conversation
@ptrendx
@ptrendxptrendx
commented
Mar 10, 2023

Copy link


Copy Markdown

Member
As we move forward with the support for multiple frameworks, the behavior of autodoc to import everything becomes an issue - we would need to have a container with all frameworks installed, which is going to be an issue with handling all of the dependencies. AutoAPI does not need to import the module to generate documentation, which is much better in this case.
Also add GitHub action to build the documentation.
@ptrendx
Change from AutoDoc to AutoAPI
010c363
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Fixes
191afc8
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
@ptrendx
WAR for the wrong autosummary generation
264de00
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
@ptrendx
Change common to be in line with pytorch API docs
ee1326a
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Add GitHub Action to build docs
ae42a42
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Fix
260cd3e
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Trying to fix the versions
6037e25
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
ptrendx
marked this pull request as ready for review
March 10, 2023 23:14
@ptrendx
ptrendx
commented
Mar 10, 2023

Copy link


Copy Markdown

MemberAuthor
/te-ci
timmoon10
timmoon10
approved these changes
Mar 11, 2023
View reviewed changes
@timmoon10timmoon10
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The generated docs look sensible.
ksivaman
ksivaman
reviewed
Mar 11, 2023
View reviewed changes
Comment threadtransformer_engine/pytorch/transformer.py
ksivaman
ksivaman
approved these changes
Mar 11, 2023
View reviewed changes
@ksivamanksivaman
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ksivaman
ksivaman
merged commit c9245c0
into
NVIDIA:mainMar 11, 2023
cyanguwa pushed a commit
to cyanguwa/TransformerEngine
that referenced
this pull request
Mar 31, 2023
@ptrendx@cyanguwa
Move from Sphinx Autodoc to sphinx-autoapi (NVIDIA#92)
0cb784a
* Change from AutoDoc to AutoAPI
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fixes
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* WAR for the wrong autosummary generation
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* Change common to be in line with pytorch API docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Add GitHub Action to build docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fix
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Trying to fix the versions
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
---------
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
Signed-off-by: Charlene Yang <charleney@nvidia.com>
cyanguwa pushed a commit
to cyanguwa/TransformerEngine
that referenced
this pull request
Apr 1, 2023
@ptrendx@cyanguwa
Move from Sphinx Autodoc to sphinx-autoapi (NVIDIA#92)
9dac379
* Change from AutoDoc to AutoAPI
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fixes
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* WAR for the wrong autosummary generation
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* Change common to be in line with pytorch API docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Add GitHub Action to build docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fix
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Trying to fix the versions
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
---------
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
Signed-off-by: Charlene Yang <charleney@nvidia.com>
zhiyu-deep pushed a commit
to zhiyu-deep/TransformerEngine
that referenced
this pull request
Sep 3, 2024
@Anerudhan
cudnn FE 1.6.0
924307e
New API (NVIDIA#92)
- Graph Slice Operation: Introduced the graph.slice operation for slicing input tensors. Refer to docs/operations/Slice.md for detailed documentation and samples/cpp/misc/slice.cpp for a C++ sample. Pybinds for this operation have also been added.
- SM Carveout Feature: Added the set_sm_count(int32_t type) graph property to support the SM Carveout feature introduced in Ampere and Hopper GPUs. Engines that do not support SM_COUNT will return NOT_SUPPORTED.
Bug Fixes
- Convolution Mode Attribute: Added the missing set_convolution_mode attribute to convolution attributes in forward propagation (fprop), data gradient (dgrad), and weight gradient (wgrad). Previously, this was hardcoded to CUDNN_CROSS_CORRELATION in the 1.x API.
- SDPA FP8 Backward Node: Fixed an issue with the deserialization of the sdpa_fp8_backward node.
Enhancements
- Graph Execution Overhead: Reduced the overhead of graph.execute() by optimizing sub-node tree traversal, collected UIDs, workspace modifications, and workspace size.
- Graph Validation Performance: Significantly improved (~10x) the performance of graph.validate() by deferring graph expansion to a later stage (build_operation_graph).
- Optional Running Stats for BatchNorm: Made the running statistics for the batch normalization operation optional, supported by cuDNN backend version 9.3.0 and later.
- Shape and Stride Inferencing: Enhanced shape and stride inferencing to preserve the stride order of the input.
- Diagnostic Error Message: Added a diagnostic error message to create_execution_plans if called without the preceding build_operation_graph.
- JSON Schema and Deserialization: Improved the JSON schema and deserialization logic with additional checks.
- Logging Overhead: Reduced logging overhead, resulting in faster graph.build() calls.
- CMake Integration: Replaced CMAKE_SOURCE_DIR with PROJECT_SOURCE_DIR in CMake files for better integration. See the relevant pull request for more details.
Samples
- Jupyter Notebooks: Added Jupyter notebooks for RMSNorm, InstanceNorm, and LayerNorm. Refer to the samples/python folder for more information.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@timmoon10timmoon10timmoon10 approved these changes
@ksivamanksivamanksivaman approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ptrendx@timmoon10@ksivaman

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Move from Sphinx Autodoc to sphinx-autoapi by ptrendx · Pull Request #92 · NVIDIA/TransformerEngine · GitHub
Skip to content
Move from Sphinx Autodoc to sphinx-autoapi - #92
Merged
ksivaman merged 7 commits into
NVIDIA:mainfrom 
ptrendx:pr_autoapi
Mar 11, 2023
Merged
Move from Sphinx Autodoc to sphinx-autoapi#92
ksivaman merged 7 commits into
NVIDIA:mainfrom 
ptrendx:pr_autoapi
Conversation
@ptrendx
@ptrendxptrendx
commented
Mar 10, 2023

Copy link


Copy Markdown

Member
As we move forward with the support for multiple frameworks, the behavior of autodoc to import everything becomes an issue - we would need to have a container with all frameworks installed, which is going to be an issue with handling all of the dependencies. AutoAPI does not need to import the module to generate documentation, which is much better in this case.
Also add GitHub action to build the documentation.
@ptrendx
Change from AutoDoc to AutoAPI
010c363
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Fixes
191afc8
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
@ptrendx
WAR for the wrong autosummary generation
264de00
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
@ptrendx
Change common to be in line with pytorch API docs
ee1326a
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Add GitHub Action to build docs
ae42a42
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Fix
260cd3e
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Trying to fix the versions
6037e25
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
ptrendx
marked this pull request as ready for review
March 10, 2023 23:14
@ptrendx
ptrendx
commented
Mar 10, 2023

Copy link


Copy Markdown

MemberAuthor
/te-ci
timmoon10
timmoon10
approved these changes
Mar 11, 2023
View reviewed changes
@timmoon10timmoon10
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The generated docs look sensible.
ksivaman
ksivaman
reviewed
Mar 11, 2023
View reviewed changes
Comment threadtransformer_engine/pytorch/transformer.py
ksivaman
ksivaman
approved these changes
Mar 11, 2023
View reviewed changes
@ksivamanksivaman
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ksivaman
ksivaman
merged commit c9245c0
into
NVIDIA:mainMar 11, 2023
cyanguwa pushed a commit
to cyanguwa/TransformerEngine
that referenced
this pull request
Mar 31, 2023
@ptrendx@cyanguwa
Move from Sphinx Autodoc to sphinx-autoapi (NVIDIA#92)
0cb784a
* Change from AutoDoc to AutoAPI
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fixes
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* WAR for the wrong autosummary generation
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* Change common to be in line with pytorch API docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Add GitHub Action to build docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fix
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Trying to fix the versions
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
---------
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
Signed-off-by: Charlene Yang <charleney@nvidia.com>
cyanguwa pushed a commit
to cyanguwa/TransformerEngine
that referenced
this pull request
Apr 1, 2023
@ptrendx@cyanguwa
Move from Sphinx Autodoc to sphinx-autoapi (NVIDIA#92)
9dac379
* Change from AutoDoc to AutoAPI
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fixes
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* WAR for the wrong autosummary generation
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* Change common to be in line with pytorch API docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Add GitHub Action to build docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fix
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Trying to fix the versions
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
---------
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
Signed-off-by: Charlene Yang <charleney@nvidia.com>
zhiyu-deep pushed a commit
to zhiyu-deep/TransformerEngine
that referenced
this pull request
Sep 3, 2024
@Anerudhan
cudnn FE 1.6.0
924307e
New API (NVIDIA#92)
- Graph Slice Operation: Introduced the graph.slice operation for slicing input tensors. Refer to docs/operations/Slice.md for detailed documentation and samples/cpp/misc/slice.cpp for a C++ sample. Pybinds for this operation have also been added.
- SM Carveout Feature: Added the set_sm_count(int32_t type) graph property to support the SM Carveout feature introduced in Ampere and Hopper GPUs. Engines that do not support SM_COUNT will return NOT_SUPPORTED.
Bug Fixes
- Convolution Mode Attribute: Added the missing set_convolution_mode attribute to convolution attributes in forward propagation (fprop), data gradient (dgrad), and weight gradient (wgrad). Previously, this was hardcoded to CUDNN_CROSS_CORRELATION in the 1.x API.
- SDPA FP8 Backward Node: Fixed an issue with the deserialization of the sdpa_fp8_backward node.
Enhancements
- Graph Execution Overhead: Reduced the overhead of graph.execute() by optimizing sub-node tree traversal, collected UIDs, workspace modifications, and workspace size.
- Graph Validation Performance: Significantly improved (~10x) the performance of graph.validate() by deferring graph expansion to a later stage (build_operation_graph).
- Optional Running Stats for BatchNorm: Made the running statistics for the batch normalization operation optional, supported by cuDNN backend version 9.3.0 and later.
- Shape and Stride Inferencing: Enhanced shape and stride inferencing to preserve the stride order of the input.
- Diagnostic Error Message: Added a diagnostic error message to create_execution_plans if called without the preceding build_operation_graph.
- JSON Schema and Deserialization: Improved the JSON schema and deserialization logic with additional checks.
- Logging Overhead: Reduced logging overhead, resulting in faster graph.build() calls.
- CMake Integration: Replaced CMAKE_SOURCE_DIR with PROJECT_SOURCE_DIR in CMake files for better integration. See the relevant pull request for more details.
Samples
- Jupyter Notebooks: Added Jupyter notebooks for RMSNorm, InstanceNorm, and LayerNorm. Refer to the samples/python folder for more information.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@timmoon10timmoon10timmoon10 approved these changes
@ksivamanksivamanksivaman approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ptrendx@timmoon10@ksivaman

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Move from Sphinx Autodoc to sphinx-autoapi by ptrendx · Pull Request #92 · NVIDIA/TransformerEngine · GitHub
Skip to content
Move from Sphinx Autodoc to sphinx-autoapi - #92
Merged
ksivaman merged 7 commits into
NVIDIA:mainfrom 
ptrendx:pr_autoapi
Mar 11, 2023
Merged
Move from Sphinx Autodoc to sphinx-autoapi#92
ksivaman merged 7 commits into
NVIDIA:mainfrom 
ptrendx:pr_autoapi
Conversation
@ptrendx
@ptrendxptrendx
commented
Mar 10, 2023

Copy link


Copy Markdown

Member
As we move forward with the support for multiple frameworks, the behavior of autodoc to import everything becomes an issue - we would need to have a container with all frameworks installed, which is going to be an issue with handling all of the dependencies. AutoAPI does not need to import the module to generate documentation, which is much better in this case.
Also add GitHub action to build the documentation.
@ptrendx
Change from AutoDoc to AutoAPI
010c363
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Fixes
191afc8
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
@ptrendx
WAR for the wrong autosummary generation
264de00
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
@ptrendx
Change common to be in line with pytorch API docs
ee1326a
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Add GitHub Action to build docs
ae42a42
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Fix
260cd3e
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
Trying to fix the versions
6037e25
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
@ptrendx
ptrendx
marked this pull request as ready for review
March 10, 2023 23:14
@ptrendx
ptrendx
commented
Mar 10, 2023

Copy link


Copy Markdown

MemberAuthor
/te-ci
timmoon10
timmoon10
approved these changes
Mar 11, 2023
View reviewed changes
@timmoon10timmoon10
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The generated docs look sensible.
ksivaman
ksivaman
reviewed
Mar 11, 2023
View reviewed changes
Comment threadtransformer_engine/pytorch/transformer.py
ksivaman
ksivaman
approved these changes
Mar 11, 2023
View reviewed changes
@ksivamanksivaman
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ksivaman
ksivaman
merged commit c9245c0
into
NVIDIA:mainMar 11, 2023
cyanguwa pushed a commit
to cyanguwa/TransformerEngine
that referenced
this pull request
Mar 31, 2023
@ptrendx@cyanguwa
Move from Sphinx Autodoc to sphinx-autoapi (NVIDIA#92)
0cb784a
* Change from AutoDoc to AutoAPI
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fixes
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* WAR for the wrong autosummary generation
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* Change common to be in line with pytorch API docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Add GitHub Action to build docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fix
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Trying to fix the versions
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
---------
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
Signed-off-by: Charlene Yang <charleney@nvidia.com>
cyanguwa pushed a commit
to cyanguwa/TransformerEngine
that referenced
this pull request
Apr 1, 2023
@ptrendx@cyanguwa
Move from Sphinx Autodoc to sphinx-autoapi (NVIDIA#92)
9dac379
* Change from AutoDoc to AutoAPI
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fixes
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* WAR for the wrong autosummary generation
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
* Change common to be in line with pytorch API docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Add GitHub Action to build docs
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Fix
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
* Trying to fix the versions
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
---------
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
Signed-off-by: Przemyslaw Tredak <ptredak@nvidia.com>
Signed-off-by: Charlene Yang <charleney@nvidia.com>
zhiyu-deep pushed a commit
to zhiyu-deep/TransformerEngine
that referenced
this pull request
Sep 3, 2024
@Anerudhan
cudnn FE 1.6.0
924307e
New API (NVIDIA#92)
- Graph Slice Operation: Introduced the graph.slice operation for slicing input tensors. Refer to docs/operations/Slice.md for detailed documentation and samples/cpp/misc/slice.cpp for a C++ sample. Pybinds for this operation have also been added.
- SM Carveout Feature: Added the set_sm_count(int32_t type) graph property to support the SM Carveout feature introduced in Ampere and Hopper GPUs. Engines that do not support SM_COUNT will return NOT_SUPPORTED.
Bug Fixes
- Convolution Mode Attribute: Added the missing set_convolution_mode attribute to convolution attributes in forward propagation (fprop), data gradient (dgrad), and weight gradient (wgrad). Previously, this was hardcoded to CUDNN_CROSS_CORRELATION in the 1.x API.
- SDPA FP8 Backward Node: Fixed an issue with the deserialization of the sdpa_fp8_backward node.
Enhancements
- Graph Execution Overhead: Reduced the overhead of graph.execute() by optimizing sub-node tree traversal, collected UIDs, workspace modifications, and workspace size.
- Graph Validation Performance: Significantly improved (~10x) the performance of graph.validate() by deferring graph expansion to a later stage (build_operation_graph).
- Optional Running Stats for BatchNorm: Made the running statistics for the batch normalization operation optional, supported by cuDNN backend version 9.3.0 and later.
- Shape and Stride Inferencing: Enhanced shape and stride inferencing to preserve the stride order of the input.
- Diagnostic Error Message: Added a diagnostic error message to create_execution_plans if called without the preceding build_operation_graph.
- JSON Schema and Deserialization: Improved the JSON schema and deserialization logic with additional checks.
- Logging Overhead: Reduced logging overhead, resulting in faster graph.build() calls.
- CMake Integration: Replaced CMAKE_SOURCE_DIR with PROJECT_SOURCE_DIR in CMake files for better integration. See the relevant pull request for more details.
Samples
- Jupyter Notebooks: Added Jupyter notebooks for RMSNorm, InstanceNorm, and LayerNorm. Refer to the samples/python folder for more information.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@timmoon10timmoon10timmoon10 approved these changes
@ksivamanksivamanksivaman approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ptrendx@timmoon10@ksivaman