Skip to content

libcu++: silence msvc+nvcc12.9 warning plaguing c.parallel. #7144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
griwes merged 5 commits into from
Jan 9, 2026
Merged

libcu++: silence msvc+nvcc12.9 warning plaguing c.parallel. #7144

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9c01f22
libcu++: silence msvc+nvcc12.9 warning plaguing c.parallel.
griwes Jan 9, 2026
725d8a5
Merge remote-tracking branch 'origin/main' into bug/c-parallel-msvc-e…
griwes Jan 9, 2026
0c5898e
Undo matrix override.
griwes Jan 9, 2026
fac05bf
Merge branch 'main' into bug/c-parallel-msvc-error
griwes Jan 9, 2026
d32b406
Apply suggestion from @davebayer
davebayer Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions libcudacxx/include/cuda/std/__complex/roots.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,13 @@ template <class _Tp>
// pre-check to see if we over/underflow:
_Tp __x_abs_sq = ::cuda::std::fma(__re, __re, __im * __im);

// NVCC 12.9 seems to be eliminating some parentheses which makes MSVC unhappy.
_CCCL_DIAG_PUSH
#if _CCCL_CUDA_COMPILER(NVCC, <, 13, 0)
_CCCL_DIAG_SUPPRESS_MSVC(4554) // warning C4554: '<<': check operator precedence for possible error; use parentheses
// to clarify precedence
#endif // _CCCL_CUDA_COMPILER(NVCC, <, 13, 0)

// Get some bounds where __re +- |__x| won't overflow.
// Doesn't need to be too exact, enough to cover extremal cases.
// overflow bound = sqrt(MAX_FLOAT / 2)
Expand All @@ -87,6 +94,8 @@ template <class _Tp>
(static_cast<__uint_t>((static_cast<__uint_t>(-__max_exponent + __mant_nbits) >> 1) + __exp_bias) << __mant_nbits)
| __fp_explicit_bit_mask_of_v<_Tp>;

_CCCL_DIAG_POP

@miscco miscco Jan 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the warning suppression outof the function. We have multiple similar bit operations and I dont want that to reappear

@griwes griwes Jan 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were the only ones triggering it and I'd rather be narrow with silencing like this, to avoid getting false negatives without inspection.


_Tp __overflow_bound = ::cuda::std::__fp_from_storage<_Tp>(__overflow_bound_exp);
_Tp __underflow_bound = ::cuda::std::__fp_from_storage<_Tp>(__underflow_bound_exp);

Expand Down