Remove _CCCL_GRID_CONSTANT from scan kernel - #9854
bernhardmgruber wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe scan initialization and execution kernel signatures in ChangesScan kernel signature updates
Assessment against linked issues
Possibly related PRs
Suggested reviewers: Comment |
|
#9851 lists the Ampere regressions/fix. How does this PR influence behaviour on other architectures, e.g., look-ahead-enabled ones? Asking, because, I've previously seen both directions with |
|
That's a fair point. I only benchmarked that this PR mitigates the regression on Ampere. I did not check the impact on other architectures. Here is CCCL 3.4 vs this PR on A100: |
😬 CI Workflow Results🟥 Finished in 2h 30m: Pass: 99%/287 | Total: 12d 06h | Max: 2h 29m | Hits: 19%/1025041See results here. |
|
this pr against main does not regress on b200 |
|
Closed in favor of: #9858 |
Fixes: #9851