Uh oh!
There was an error while loading. Please reload this page.
Add rank order option to grid descriptor configuration. - #119
Merged
Conversation
Signed-off-by: Josh Romero <joshr@nvidia.com>
Signed-off-by: Josh Romero <joshr@nvidia.com>
Signed-off-by: Josh Romero <joshr@nvidia.com>
romerojosh
commented
Apr 29, 2026
CollaboratorAuthor
/build |
🚀 Build workflow triggered! View run |
✅ Build workflow passed! View run |
Signed-off-by: Josh Romero <joshr@nvidia.com>
Signed-off-by: Josh Romero <joshr@nvidia.com>
Signed-off-by: Josh Romero <joshr@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #85, an option to make cuDecomp use column major rank assignment was made available via an environment variable
CUDECOMP_USE_COL_MAJOR_RANK_ORDER. In practice, using this functionality can be a bit awkward as programs that depend on it require checks on the user environment (via something likegetenv) to ensure the environment variable is set appropriately.This PR addresses this by adding a new field,
rank_orderto the grid descriptor configuration struct to enable per grid descriptor settings of the rank assignment. A new enumcudecompRankOrder_tis added to enable users to select from default/row-major (CUDECOMP_RANK_ORDER_DEFAULT/CUDECOMP_RANK_ORDER_ROW_MAJOR) or column-major (CUDECOMP_RANK_ORDER_COL_MAJOR). Importantly, this makes the rank assignment expectation a programmatic setting rather than awkwardly relying on environment variable settings.As part of this PR, the
CUDECOMP_USE_COL_MAJOR_RANK_ORDERenv var functionality is deprecated. It will be honored ifCUDECOMP_RANK_ORDER_DEFAULTis used, ignored otherwise. This feature will be removed in a future release.Noting that this is an ABI break since it alters the configuration struct layout.