Uh oh!
There was an error while loading. Please reload this page.
Remove redundant NCCL AlltoAll runtime check - #157
Merged
Conversation
Signed-off-by: romerojosh <joshr@nvidia.com>
romerojosh
commented
Jul 21, 2026
CollaboratorAuthor
/build |
🚀 Build workflow triggered! View run |
✅ Build workflow passed! View run |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#136 introduced usage of the native
ncclAlltoAllAPI to the transpose paths. This PR introduced a misleading check on the runtime NCCL version, suggesting that users could link an older runtime NCCL version to a cuDecomp library built against a newer NCCL version. This is not generally supported so this PR removes that check.