Skip to content

chore(deps): bump precommit versions - #1017

Merged
kkraus14 merged 3 commits into
NVIDIA:mainfrom
cpcloud:bump-precommit-versions
Sep 30, 2025
Merged

chore(deps): bump precommit versions#1017
kkraus14 merged 3 commits into
NVIDIA:mainfrom
cpcloud:bump-precommit-versions

Conversation

@cpcloud

@cpcloudcpcloud commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

Run autoupdate freeze on pre-commit and autofixed the lints produced by a newer version of ruff.

@copy-pr-bot

copy-pr-botBot commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cpcloudcpcloud changed the title bump precommit versionschore(deps): bump precommit versionsSep 25, 2025
@leofang

leofang commented Sep 25, 2025

Copy link
Copy Markdown
Member

The new grouping of import statements is very annoying, we have been grouping the imports following PEP 8 just fine and it's now broken. Can we please just skip whatever new rule is implemented in Ruff?

@leofang
leofang requested a review from rwgkSeptember 25, 2025 14:45
@cpcloud

cpcloud commented Sep 25, 2025

Copy link
Copy Markdown
ContributorAuthor

Broken feels a bit extreme--the code still runs--but that's fine by me. PEP8 is probably not something we should religiously follow FWIW, it has its problems.

@cpcloud

cpcloud commented Sep 25, 2025

Copy link
Copy Markdown
ContributorAuthor

In any case, I'll revert those changes.

@cpcloud

cpcloud commented Sep 25, 2025

Copy link
Copy Markdown
ContributorAuthor

@leofang I think the import modifications are correct actually. Notice that not every file is formatted, so this is just bringing various other files in line with the rest of the codebase.

kkraus14
kkraus14 reviewed Sep 25, 2025
View reviewed changes
Comment thread.github/workflows/bandit.yml Outdated
@cpcloud
cpcloudforce-pushed the bump-precommit-versions branch 3 times, most recently from 2606cdc to 0059ccaCompareSeptember 29, 2025 17:03
kkraus14
kkraus14 reviewed Sep 29, 2025
View reviewed changes
Comment thread.pre-commit-config.yaml Outdated
@cpcloud
cpcloudforce-pushed the bump-precommit-versions branch from 0059cca to 69217c2CompareSeptember 29, 2025 19:55
@rwgk

rwgk commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

/ok to test

@github-actions

This comment has been minimized.

Sign in to view
@kkraus14
kkraus14 merged commit 6f900d7 into NVIDIA:mainSep 30, 2025
70 checks passed
@github-actions

github-actionsBot commented Sep 30, 2025

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

@leofangleofang added this to the cuda.core beta 7 milestone Oct 9, 2025
@leofangleofang added enhancement Any code-related improvements support All things related to the project that can't be categorized labels Oct 9, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwgkrwgkrwgk approved these changes
@kkraus14kkraus14kkraus14 approved these changes

Assignees

@cpcloudcpcloud

Labels

enhancementAny code-related improvementssupportAll things related to the project that can't be categorized

Projects

None yet

Milestone

cuda.core beta 7

Development

Successfully merging this pull request may close these issues.

4 participants

@cpcloud@leofang@rwgk@kkraus14