Skip to content

[Backport 12.9.x] test_nvvm.py simplification / use llvmlite in toolshed/ only - #1053

Merged
rwgk merged 1 commit into
12.9.xfrom
backport-1047-to-12.9.x
Oct 1, 2025
Merged

[Backport 12.9.x] test_nvvm.py simplification / use llvmlite in toolshed/ only#1053
rwgk merged 1 commit into
12.9.xfrom
backport-1047-to-12.9.x

Conversation

@github-actions

Copy link
Copy Markdown

Description

Backport of #1047 to 12.9.x.

* Remove bitcode_dynamic code from test_nvvm.py
* New toolshed/build_static_bitcode_input.py
* Import test_nvvm to get access to MINIMAL_NVVMIR_TXT (to avoid duplicating it).
* Rename MINIMAL_NVVMIR_TXT → MINIMAL_NVVMIR_TXT_TEMPLATE for clarity.
* Minor simplifications of helper script.
(cherry picked from commit 5383cb5)
@copy-pr-bot

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@rwgk

rwgk commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

@leofang Should I keep or revert the toolshed/ addition in this backport PR?

@rwgk
rwgk requested a review from leofangSeptember 30, 2025 19:12
@rwgkrwgk added the cuda.bindings Everything related to the cuda.bindings module label Sep 30, 2025
@leofang

Copy link
Copy Markdown
Member

no need to touch any files unless they are relevant for testing older cuda-bindings in the CI, but since the bot did the work already, it's fine to keep

@leofangleofang added P1 Medium priority - Should do test Improvements or additions to tests labels Sep 30, 2025
@rwgk

rwgk commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

/ok to test

@copy-pr-bot

Copy link
Copy Markdown
Contributor

/ok to test

@rwgk, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@rwgk

rwgk commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

/ok to test 4f45ffa

@rwgk
rwgk merged commit 9b579bc into 12.9.xOct 1, 2025
50 checks passed
@rwgk
rwgk deleted the backport-1047-to-12.9.x branch October 1, 2025 00:20
@cpcloudcpcloud mentioned this pull request Oct 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.bindingsEverything related to the cuda.bindings moduleP1Medium priority - Should dotestImprovements or additions to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rwgk@leofang