Skip to content

Fix editable installation for cuda-core - #1091

Merged
leofang merged 1 commit into
NVIDIA:mainfrom
leofang:fix_editable
Oct 6, 2025
Merged

Fix editable installation for cuda-core#1091
leofang merged 1 commit into
NVIDIA:mainfrom
leofang:fix_editable

Conversation

@leofang

@leofangleofang commented Oct 6, 2025

Copy link
Copy Markdown
Member

Description

Close#1088.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@leofangleofang self-assigned this Oct 6, 2025
@copy-pr-bot

copy-pr-botBot commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@kkraus14

kkraus14 commented Oct 6, 2025

Copy link
Copy Markdown
Collaborator

Tested locally and worked with both uv pip install --system -v -e . and pip install -v -e .

@leofangleofang added bug Something isn't working P0 High priority - Must do! packaging Anything related to wheels or Conda packages cuda.core Everything related to the cuda.core module labels Oct 6, 2025
@leofangleofang added this to the cuda.core beta 7 milestone Oct 6, 2025
@leofang

leofang commented Oct 6, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test c97f405

@leofangleofang mentioned this pull request Oct 6, 2025
Closed
@github-actions

This comment has been minimized.

Sign in to view
rwgk
rwgk approved these changes Oct 6, 2025
View reviewed changes

@rwgkrwgk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally tested: I rebuilt from scratch using -e for pathfinder, bindings, core, then ran the tests.

(I glanced through the changes but don't understand them enough to meaningfully review.)

@leofang

leofang commented Oct 6, 2025

Copy link
Copy Markdown
MemberAuthor

(I glanced through the changes but don't understand them enough to meaningfully review.)

The tl;dr is that when implementing a custom build frontend (our build_hooks.py), we are required to implement hooks from both PEP-517 and PEP-660, the latter of which are needed for editable install. I kept it as a TODO back in #1041, hoping that no one would try to do -e before I circle back to work on this. I was wrong.

@leofang
leofang enabled auto-merge (squash) October 6, 2025 19:08
@leofang
leofang merged commit 8ddbb42 into NVIDIA:mainOct 6, 2025
75 checks passed
@leofang
leofang deleted the fix_editable branch October 6, 2025 19:29
@github-actions

github-actionsBot commented Oct 6, 2025

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwgkrwgkrwgk approved these changes
@kkraus14kkraus14kkraus14 approved these changes

Assignees

@leofangleofang

Labels

bugSomething isn't workingcuda.coreEverything related to the cuda.core moduleP0High priority - Must do!packagingAnything related to wheels or Conda packages

Projects

None yet

Milestone

cuda.core beta 7

Development

Successfully merging this pull request may close these issues.

cuda-core editable install is broken

3 participants

@leofang@kkraus14@rwgk