Skip to content

Avoid adding __dict__ to every child class - #1104

Merged
cpcloud merged 4 commits into
NVIDIA:mainfrom
leofang:remove_dict
Oct 8, 2025
Merged

Avoid adding __dict__ to every child class#1104
cpcloud merged 4 commits into
NVIDIA:mainfrom
leofang:remove_dict

Conversation

@leofang

@leofangleofang commented Oct 8, 2025

Copy link
Copy Markdown
Member

Description

closes

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot

copy-pr-botBot commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

cpcloud
cpcloud previously approved these changes Oct 8, 2025
View reviewed changes
@leofang

leofang commented Oct 8, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test f3c9d0f

@github-actions

This comment has been minimized.

Sign in to view
@leofangleofang self-assigned this Oct 8, 2025
@leofangleofang added bug Something isn't working P0 High priority - Must do! cuda.core Everything related to the cuda.core module labels Oct 8, 2025
@leofangleofang added this to the cuda.core beta 7 milestone Oct 8, 2025
@leofangleofang mentioned this pull request Oct 8, 2025
Closed
2 tasks
@leofang
leofang marked this pull request as ready for review October 8, 2025 15:03
@leofang

leofang commented Oct 8, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test 5d64b51

cpcloud
cpcloud suggested changes Oct 8, 2025
View reviewed changes
Comment threadcuda_core/cuda/core/experimental/_memory.pyx Outdated
@leofang

leofang commented Oct 8, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test 46d1e34

@leofang

leofang commented Oct 8, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test 43953f9

@leofang

leofang commented Oct 8, 2025

Copy link
Copy Markdown
MemberAuthor

CI is green, finally!

@cpcloudcpcloud mentioned this pull request Oct 8, 2025
Merged
@leofangleofang mentioned this pull request Oct 8, 2025
Closed
@cpcloud
cpcloud merged commit 4754292 into NVIDIA:mainOct 8, 2025
71 checks passed
@leofang
leofang deleted the remove_dict branch October 8, 2025 17:41
@github-actions

github-actionsBot commented Oct 8, 2025

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@cpcloudcpcloudcpcloud approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@leofangleofang

Labels

bugSomething isn't workingcuda.coreEverything related to the cuda.core moduleP0High priority - Must do!

Projects

None yet

Milestone

cuda.core beta 7

Development

Successfully merging this pull request may close these issues.

2 participants

@leofang@cpcloud