Skip to content

Avoid accessing self's Python attributes in __dealloc__ - #1105

Merged
leofang merged 1 commit into
NVIDIA:mainfrom
leofang:fix_dealloc
Oct 8, 2025
Merged

Avoid accessing self's Python attributes in __dealloc__#1105
leofang merged 1 commit into
NVIDIA:mainfrom
leofang:fix_dealloc

Conversation

@leofang

@leofangleofang commented Oct 8, 2025

Copy link
Copy Markdown
Member

Description

closes

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot

copy-pr-botBot commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofangleofang self-assigned this Oct 8, 2025
@leofangleofang added bug Something isn't working P0 High priority - Must do! cuda.core Everything related to the cuda.core module labels Oct 8, 2025
@leofangleofang added this to the cuda.core beta 7 milestone Oct 8, 2025
@leofang

leofang commented Oct 8, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test ae55db6

@leofangleofang mentioned this pull request Oct 8, 2025
Closed
2 tasks
@leofang
leofang enabled auto-merge (squash) October 8, 2025 14:57
@github-actions

This comment has been minimized.

Sign in to view
@leofang
leofang merged commit e32892c into NVIDIA:mainOct 8, 2025
72 of 74 checks passed
@leofang

leofang commented Oct 8, 2025

Copy link
Copy Markdown
MemberAuthor

The status check is not doing the job right. There are failed runs (due to network glitches) being ignored. Discussing internally.

@leofang
leofang deleted the fix_dealloc branch October 8, 2025 15:45
@github-actions

github-actionsBot commented Oct 8, 2025

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

This was referenced Oct 8, 2025
Merged
Merged
@leofangleofang mentioned this pull request Oct 8, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwinashwinashwina approved these changes
@Andy-JostAndy-JostAwaiting requested review from Andy-Jost
+1 more reviewer
@cpcloudcpcloudcpcloud approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@leofangleofang

Labels

bugSomething isn't workingcuda.coreEverything related to the cuda.core moduleP0High priority - Must do!

Projects

None yet

Milestone

cuda.core beta 7

Development

Successfully merging this pull request may close these issues.

3 participants

@leofang@cpcloud@shwina