Skip to content

Fix VMM tests - #1277

Closed
leofang wants to merge 3 commits into
NVIDIA:mainfrom
leofang:fix_vmm_tests
Closed

Fix VMM tests#1277
leofang wants to merge 3 commits into
NVIDIA:mainfrom
leofang:fix_vmm_tests

Conversation

@leofang

@leofangleofang commented Nov 20, 2025

Copy link
Copy Markdown
Member

Description

follow-up of #1242
closes#1276

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@leofangleofang self-assigned this Nov 20, 2025
@leofangleofang added bug Something isn't working P0 High priority - Must do! test Improvements or additions to tests cuda.core Everything related to the cuda.core module labels Nov 20, 2025
@copy-pr-bot

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofangleofang added this to the cuda.core beta 10 milestone Nov 20, 2025
@leofang

Copy link
Copy Markdown
MemberAuthor

/ok to test 3dd1bc5

@leofang

Copy link
Copy Markdown
MemberAuthor

Ah... On the self-hosted Windows runners we don't have MSVC, so CFFI would not work 😞

@github-actions

Copy link
Copy Markdown

@kkraus14

Copy link
Copy Markdown
Collaborator

My 2c: having this OBJECT_ATTRIBUTE directly exposed to cuda.core doesn't make sense where I wonder if we can pull out the key functionality that is needed from it and support those more directly via args/kwargs to hide this as an implementation detail from users. If they need the low level functionality they can always reach for cuda.bindings.driver.

@leofang

Copy link
Copy Markdown
MemberAuthor

Discussed during the meeting, we want to hide this for now and raise an exception asking users to reach out to us if they use handle_type="win32". I'll prepare another PR to do this.

@leofangleofang closed this Nov 21, 2025
@leofang
leofang deleted the fix_vmm_tests branch November 21, 2025 04:51
github-actionsBot pushed a commit that referenced this pull request Nov 22, 2025
Removed preview folders for the following PRs:
- PR #1277
@leofangleofang mentioned this pull request Dec 3, 2025
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't workingcuda.coreEverything related to the cuda.core moduleP0High priority - Must do!testImprovements or additions to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix VMM test suite

2 participants

@leofang@kkraus14