Skip to content

Prerelease NVML bindings - #1284

Merged
mdboom merged 18 commits into
NVIDIA:mainfrom
mdboom:nvml
Dec 9, 2025
Merged

Prerelease NVML bindings#1284
mdboom merged 18 commits into
NVIDIA:mainfrom
mdboom:nvml

Conversation

@mdboom

@mdboommdboom commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@copy-pr-bot

copy-pr-botBot commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@leofangleofang linked an issue Nov 24, 2025 that may be closed by this pull request
Add nvml bindings #863
Closed
1 task
@leofangleofang added P0 High priority - Must do! feature New feature or request cuda.bindings Everything related to the cuda.bindings module labels Nov 24, 2025
@mdboom

mdboom commented Nov 24, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@github-actions

This comment has been minimized.

Sign in to view
@mdboom

mdboom commented Nov 24, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

rwgk
rwgk reviewed Nov 25, 2025
View reviewed changes
Comment threadcuda_bindings/cuda/bindings/_internal/nvml_windows.pyx Outdated
@rwgkrwgk mentioned this pull request Nov 26, 2025
Closed
@mdboom

mdboom commented Dec 1, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@mdboom

mdboom commented Dec 1, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@mdboom

mdboom commented Dec 1, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@mdboom

mdboom commented Dec 1, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@leofang

leofang commented Dec 1, 2025

Copy link
Copy Markdown
Member

Let's get #1244 merged first to reduce the diff (from cufile).

@mdboom

mdboom commented Dec 2, 2025

Copy link
Copy Markdown
ContributorAuthor

Let's get #1244 merged first to reduce the diff (from cufile).

Yes, if we want to merge #1244 before 13.1 (I'm not sure that we do).

@mdboom

mdboom commented Dec 2, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@mdboom

mdboom commented Dec 2, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@mdboom

mdboom commented Dec 2, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@mdboom

mdboom commented Dec 2, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@mdboom
mdboom marked this pull request as ready for review December 3, 2025 16:02
@copy-pr-bot

copy-pr-botBot commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

kkraus14
kkraus14 previously requested changes Dec 3, 2025
View reviewed changes

@kkraus14kkraus14 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes purely to prevent merging shortly before release 😄

@mdboom

mdboom commented Dec 8, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@kkraus14
kkraus14 dismissed their stale reviewDecember 8, 2025 16:20

Release is out :)

@mdboom

mdboom commented Dec 8, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

rwgk
rwgk reviewed Dec 8, 2025
View reviewed changes

@rwgkrwgk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple basic things that stood out to me while glancing through.

Comment threadcuda_bindings/tests/nvml/test_pynvml.py
Comment threadcuda_bindings/tests/nvml/conftest.py Outdated
Comment threadcuda_bindings/tests/nvml/conftest.py Outdated
kkraus14
kkraus14 approved these changes Dec 9, 2025
View reviewed changes

@kkraus14kkraus14 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than @rwgk's comments 😄

@mdboom

mdboom commented Dec 9, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@mdboom
mdboom enabled auto-merge (squash) December 9, 2025 14:01
@mdboom
mdboom merged commit df394be into NVIDIA:mainDec 9, 2025
80 checks passed
@github-actions

github-actionsBot commented Dec 9, 2025

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

@mdboom
mdboom deleted the nvml branch December 9, 2025 16:12
@leofang

leofang commented Jan 14, 2026

Copy link
Copy Markdown
Member

Backported in #1349.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwgkrwgkrwgk left review comments
@leofangleofangleofang left review comments
@kkraus14kkraus14kkraus14 approved these changes

Assignees

@mdboommdboom

Labels

cuda.bindingsEverything related to the cuda.bindings modulefeatureNew feature or requestP0High priority - Must do!

Projects

None yet

Milestone

cuda-python 13.1.0 & 12.9.5

Development

Successfully merging this pull request may close these issues.

Add nvml bindings

4 participants

@mdboom@leofang@rwgk@kkraus14