Skip to content

MNT: Consolidate BACKPORT_BRANCH into ci/versions.yml - #1311

Merged
leofang merged 14 commits into
NVIDIA:mainfrom
leofang:copilot/remove-backport-branch-file
Dec 15, 2025
Merged

MNT: Consolidate BACKPORT_BRANCH into ci/versions.yml#1311
leofang merged 14 commits into
NVIDIA:mainfrom
leofang:copilot/remove-backport-branch-file

Conversation

@leofang

@leofangleofang commented Dec 4, 2025

Copy link
Copy Markdown
Member

Description

closes

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

CopilotAIand others added 2 commits December 4, 2025 02:36
Initial plan
4033cfd
@leofang
Migrate BACKPORT_BRANCH from file to versions.yml
351539f
Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>
@copy-pr-bot

copy-pr-botBot commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang

leofang commented Dec 4, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test 351539f

@leofang
leofang marked this pull request as draft December 4, 2025 02:58
@leofangleofang added enhancement Any code-related improvements P1 Medium priority - Should do CI/CD CI/CD infrastructure labels Dec 4, 2025
@leofangleofang self-assigned this Dec 4, 2025
@github-actions

This comment has been minimized.

Sign in to view
@leofang

leofang commented Dec 4, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test ca9a06f

@leofang
avoid installing yq on self-hosted Linux runners...
9fdfa6c
the Debian package is unfortunately discontinued, and it is simpler if we consolidate the yq calls in the same job where yq is available
@leofang

leofang commented Dec 4, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test 9fdfa6c

@leofang

leofang commented Dec 4, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test f1af6cb

@leofang

leofang commented Dec 4, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test a26bfc5

@leofang

leofang commented Dec 5, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test e5fac2b

@leofang

leofang commented Dec 5, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test 4011bb8

@leofangleofang mentioned this pull request Dec 14, 2025
Open
@leofang

leofang commented Dec 14, 2025

Copy link
Copy Markdown
MemberAuthor

To avoid scope creep, the containerless exploration is now tracked in #1369. I'll revert and clean up the related changes to make this PR ready for review/merge.

@leofang

leofang commented Dec 14, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test 609f8a2

@leofang
leofang marked this pull request as ready for review December 14, 2025 21:18
cpcloud
cpcloud approved these changes Dec 15, 2025
View reviewed changes

@cpcloudcpcloud left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread.github/workflows/build-wheel.yml
ls -l $env:YQ_DIR
echo "$((Get-Location).Path)\\$env:YQ_DIR" >> $env:GITHUB_PATH
$env:Path += ";$((Get-Location).Path)\\$env:YQ_DIR"
yq --version

@cpcloudcpcloudDec 15, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: can we use choco install yq to minimize the amount of powershell?

@leofangleofangDec 15, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be a good idea for this workflow since choco is provided in the GH-hosted VM. I can look into it later.

I avoided using it in most places because it did not work in one of the cases (can't recall which), and we had to cover workflows running on both self-hosted and GH-hosted runners, and the asymmetry is large enough that a custom script like the one I removed for ztsd makes the portability story much better.

Comment thread.github/workflows/build-wheel.yml
@leofang
leofang merged commit 1fc792d into NVIDIA:mainDec 15, 2025
80 checks passed
@leofang

leofang commented Dec 15, 2025

Copy link
Copy Markdown
MemberAuthor

Thanks, Phillip!

@github-actions

github-actionsBot commented Dec 15, 2025

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

@leofang
leofang deleted the copilot/remove-backport-branch-file branch December 15, 2025 22:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cryoscryosAwaiting requested review from cryos
@rparolinrparolinAwaiting requested review from rparolin
1 more reviewer
@cpcloudcpcloudcpcloud approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@leofangleofang

Labels

CI/CDCI/CD infrastructureenhancementAny code-related improvementsP1Medium priority - Should do

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leofang@cpcloud