Skip to content

[cuda_pathfinder] Add CUDA 12 support to cuda-pathfinder pixi environments and removing build-variants - #1365

Merged
rparolin merged 5 commits into
NVIDIA:mainfrom
rparolin:rparolin/pixi-followup
Dec 12, 2025
Merged

[cuda_pathfinder] Add CUDA 12 support to cuda-pathfinder pixi environments and removing build-variants#1365
rparolin merged 5 commits into
NVIDIA:mainfrom
rparolin:rparolin/pixi-followup

Conversation

@rparolin

@rparolinrparolin commented Dec 11, 2025

Copy link
Copy Markdown
Collaborator
  • Add new cu12 pixi environment for CUDA 12 testing
  • Set noarch = "python" in package configuration

@copy-pr-bot

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@rparolinrparolin changed the title Add CUDA 12 support to cuda-pathfinder pixi environments[cuda_pathfinder] Add CUDA 12 support to cuda-pathfinder pixi environments and removing build-variantsDec 11, 2025
@rparolin

Copy link
Copy Markdown
CollaboratorAuthor

/ok to test 9909fe2

@rparolin
rparolin enabled auto-merge (squash) December 11, 2025 22:58
@rparolin
rparolin marked this pull request as draft December 11, 2025 22:59
auto-merge was automatically disabled December 11, 2025 22:59

Pull request was converted to draft

@github-actions

This comment has been minimized.

@rparolin

Copy link
Copy Markdown
CollaboratorAuthor

/ok to test 368793e

@rparolin
rparolin marked this pull request as ready for review December 12, 2025 00:29
@rparolin
rparolin enabled auto-merge (squash) December 12, 2025 00:29

@cpcloudcpcloud left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing major, but we should probably put a lower bound on the Python version.

Comment threadcuda_pathfinder/pixi.toml Outdated
Comment threadcuda_pathfinder/pixi.toml Outdated
Comment on lines +45 to +50
[package.run-dependencies]
python = "*"
python = ">=3.10"
setuptools = ">=64"

[package.run-dependencies]
python = ">=3.10"

@cpcloudcpcloudDec 12, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are duplicated, which is a bug. I'll add a suggestion here to fix it.

Comment threadcuda_pathfinder/pixi.toml Outdated
@kkraus14

Copy link
Copy Markdown
Collaborator

/ok to test

@copy-pr-bot

Copy link
Copy Markdown
Contributor

/ok to test

@kkraus14, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@kkraus14

Copy link
Copy Markdown
Collaborator

/ok to test aa681fd

@rparolin
rparolin merged commit e25f703 into NVIDIA:mainDec 12, 2025
80 checks passed
@github-actions

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

@leofangleofang added enhancement Any code-related improvements cuda.pathfinder Everything related to the cuda.pathfinder module labels Dec 14, 2025
@leofangleofang added the P1 Medium priority - Should do label Dec 14, 2025
@leofangleofang added this to the cuda.pathfinder 1.4.0 milestone Dec 14, 2025
rwgk added a commit to rwgk/cuda-python that referenced this pull request Dec 15, 2025
Merged latest changes from main including:
- Added size property to StridedMemoryView (NVIDIA#1363)
- NVML bindings updates (NVIDIA#1360)
- cuda_pathfinder pixi configuration (NVIDIA#1365, NVIDIA#1361)
All changes merged cleanly with no conflicts.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.pathfinderEverything related to the cuda.pathfinder moduleenhancementAny code-related improvementsP1Medium priority - Should do

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@rparolin@kkraus14@cpcloud@leofang