Skip to content

Revert StridedLayout - #1370

Merged
cpcloud merged 3 commits into
NVIDIA:mainfrom
leofang:purge_strided_layout
Dec 15, 2025
Merged

Revert StridedLayout#1370
cpcloud merged 3 commits into
NVIDIA:mainfrom
leofang:purge_strided_layout

Conversation

@leofang

@leofangleofang commented Dec 15, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Description

As per #674 (comment) this PR reverts #1283, since we'll move StridedLayout to elsewhere.

The commit from #1363 was reverted first so as to make the revert clean, but I added it back so that it's intact. The commit history should be clean enough to see how this is done.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot

copy-pr-botBot commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofangleofang changed the title WIP: Revert StridedLayoutRevert StridedLayoutDec 15, 2025
@leofangleofang self-assigned this Dec 15, 2025
@leofangleofang added this to the cuda.core beta 10 milestone Dec 15, 2025
@leofangleofang added P0 High priority - Must do! cuda.core Everything related to the cuda.core module labels Dec 15, 2025
@leofangleofang mentioned this pull request Dec 15, 2025
Merged
2 tasks
@leofang
leofang marked this pull request as ready for review December 15, 2025 17:56
@leofang

leofang commented Dec 15, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test 412ba2c

@leofang

leofang commented Dec 15, 2025

Copy link
Copy Markdown
MemberAuthor

cc @stiepan for vis

@github-actions

This comment has been minimized.

Sign in to view
cpcloud
cpcloud reviewed Dec 15, 2025
View reviewed changes
Comment threadcuda_core/docs/source/api.rst
cpcloud
cpcloud approved these changes Dec 15, 2025
View reviewed changes

@cpcloudcpcloud left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I can't say I agree with the motivation to revert this PR, it's fine to merge.

@stiepan

stiepan commented Dec 15, 2025•
edited
Loading

Copy link
Copy Markdown
Member

cc @stiepan for vis

It seems clean. Good that we moved dlpack fix out of this PR after all. 🥲

@leofang, as @cpcloud pointed out, please double check the docs page.

stiepan
stiepan reviewed Dec 15, 2025
View reviewed changes
Comment threadcuda_core/cuda/core/experimental/_memory/_buffer.pyx
@cpcloud
cpcloud enabled auto-merge (squash) December 15, 2025 19:13
@cpcloud
cpcloud merged commit d8e9317 into NVIDIA:mainDec 15, 2025
82 checks passed
@github-actions

github-actionsBot commented Dec 15, 2025

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

@cpcloudcpcloud mentioned this pull request Dec 15, 2025
Merged
cpcloud added a commit to cpcloud/cuda-python that referenced this pull request Dec 15, 2025
@cpcloud
revert: revertStridedLayout(NVIDIA#1370)
b2f6141
This reverts commit d8e9317.
leofang pushed a commit that referenced this pull request Dec 16, 2025
@cpcloud
refactor: privatizeStridedLayoutas_StridedLayout(#1373)
1f1f479
* revert: revert `StridedLayout` (#1370)
This reverts commit d8e9317.
* chore: remove strided layout from docs
* chore: privatize stridedlayout
* chore: remove unused cimports
@leofang
leofang deleted the purge_strided_layout branch December 16, 2025 00:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkraus14kkraus14Awaiting requested review from kkraus14
2 more reviewers
@cpcloudcpcloudcpcloud approved these changes
@stiepanstiepanstiepan left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@leofangleofang

Labels

cuda.coreEverything related to the cuda.core moduleP0High priority - Must do!

Projects

None yet

Milestone

cuda.core beta 10

Development

Successfully merging this pull request may close these issues.

3 participants

@leofang@stiepan@cpcloud