Uh oh!
There was an error while loading. Please reload this page.
Use setuptools-scm to determine versions - #1411
Conversation
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
mdboom
commented
Dec 18, 2025
/ok to test |
mdboom
commented
Dec 18, 2025
/ok to test |
Fancy auto versioning isn't really compatible with the "use without installing" model for this package
mdboom
commented
Dec 18, 2025
/ok to test |
…ning of the subpackages.
mdboom
commented
Dec 18, 2025
/ok to test |
cryos
left a comment
There was a problem hiding this comment.
Great to see this, I had been meaning to ask about adding in dynamic versioning. It feels a little odd hiding the rc suffix, but all projects are different. A huge step forward, thanks for working on this! Curious why we wouldn't tag and rebuild but that is orthogonal to whether this should be merged.
mdboom
commented
Dec 18, 2025
/ok to test |
rwgk
commented
Dec 19, 2025
I'm also a bit worried about doing something unusual for the |
mdboom
commented
Dec 19, 2025
/ok to test |
1 similar comment
mdboom
commented
Dec 19, 2025
/ok to test |
mdboom
commented
Dec 19, 2025
/ok to test |
mdboom
commented
Dec 19, 2025
/ok to test |
mdboom
commented
Dec 19, 2025
mdboom
commented
Dec 19, 2025
/ok to test |
mdboom
commented
Dec 19, 2025
/ok to test |
Uh oh!
There was an error while loading. Please reload this page.
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 12.9.x
git worktree add -d .worktree/backport-1411-to-12.9.x origin/12.9.x
cd .worktree/backport-1411-to-12.9.x
git switch --create backport-1411-to-12.9.x
git cherry-pick -x da7eb1f5a97aa21d8f78098e13e7c4edad013530 |
|
leofang
commented
Dec 19, 2025
leofang
commented
Dec 20, 2025
Yes, this was also the conclusion we reached on the Thursday team-sync. |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 12.9.x
git worktree add -d .worktree/backport-1411-to-12.9.x origin/12.9.x
cd .worktree/backport-1411-to-12.9.x
git switch --create backport-1411-to-12.9.x
git cherry-pick -x da7eb1f5a97aa21d8f78098e13e7c4edad013530 |
4 similar comments
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 12.9.x
git worktree add -d .worktree/backport-1411-to-12.9.x origin/12.9.x
cd .worktree/backport-1411-to-12.9.x
git switch --create backport-1411-to-12.9.x
git cherry-pick -x da7eb1f5a97aa21d8f78098e13e7c4edad013530 |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 12.9.x
git worktree add -d .worktree/backport-1411-to-12.9.x origin/12.9.x
cd .worktree/backport-1411-to-12.9.x
git switch --create backport-1411-to-12.9.x
git cherry-pick -x da7eb1f5a97aa21d8f78098e13e7c4edad013530 |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 12.9.x
git worktree add -d .worktree/backport-1411-to-12.9.x origin/12.9.x
cd .worktree/backport-1411-to-12.9.x
git switch --create backport-1411-to-12.9.x
git cherry-pick -x da7eb1f5a97aa21d8f78098e13e7c4edad013530 |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 12.9.x
git worktree add -d .worktree/backport-1411-to-12.9.x origin/12.9.x
cd .worktree/backport-1411-to-12.9.x
git switch --create backport-1411-to-12.9.x
git cherry-pick -x da7eb1f5a97aa21d8f78098e13e7c4edad013530 |
This uses the
setuptools-scmpackage to automatically determine the version of each package from the corresponding git tag.This is motivated by a couple of things:
cuda.corebased on in-development work incuda.bindings.From an offline discussion with @leofang, we have a requirement here that release candidate builds can be shipped as-is as final releases. Therefore, the tag matching regexes have been written so that:
This does have the downside that the first and second builds above, even if the hashes the tags point at are different, will have the same filename. The builds will be distinguishable by inspecting
cuda.bindings._version.__commit_id__, however.Other implications of this change:
Packages that are locally installed from git from an untagged commit will have complicated-but-helpful version numbers like
13.1.2.dev34+gecfc79fb9, so parsing them is a little more complicated than.split('.'). To help with that,setuptools-scmalso generates aversion_tuplethat dependent projects can use:but that should only effect developers installing non-released versions of our software. People installing from official packages should continue to see simple version numbers.
Building from an
sdistcontinues to work -- the tarball will contain the generated_version.pyfiles, and will be (as it should be) hardcoded with the version that thesdistwas generated from.