Skip to content

Fix #1417: Fix test for Numpy 2.4.0 - #1418

Merged
leofang merged 2 commits into
NVIDIA:mainfrom
mdboom:fix-for-numpy-2.4.0
Dec 22, 2025
Merged

Fix #1417: Fix test for Numpy 2.4.0#1418
leofang merged 2 commits into
NVIDIA:mainfrom
mdboom:fix-for-numpy-2.4.0

Conversation

@mdboom

@mdboommdboom commented Dec 22, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

closes

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot

copy-pr-botBot commented Dec 22, 2025

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@mdboommdboom self-assigned this Dec 22, 2025
@mdboom

mdboom commented Dec 22, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@mdboom

mdboom commented Dec 22, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@github-actions

This comment has been minimized.

Sign in to view
@leofangleofang linked an issue Dec 22, 2025 that may be closed by this pull request
[BUG]: Numpy 2.4.0 breaks 6 cuda.core tests #1417
Closed
1 task
@leofangleofang added P0 High priority - Must do! test Improvements or additions to tests cuda.core Everything related to the cuda.core module labels Dec 22, 2025
@leofangleofang added this to the cuda.core beta 11 milestone Dec 22, 2025
leofang
leofang approved these changes Dec 22, 2025
View reviewed changes

@leofangleofang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Mike! It is an unfortunate decision in DLPack (dmlc/dlpack#177) that propagated to NumPy (numpy/numpy#29872). I did not have a chance to intervene before the decision went out.

@leofang
leofang merged commit 46470ca into NVIDIA:mainDec 22, 2025
158 of 160 checks passed
@github-actions

github-actionsBot commented Dec 22, 2025

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

@rwgkrwgk mentioned this pull request Jan 13, 2026
Closed
github-actionsBot pushed a commit that referenced this pull request Jan 13, 2026
@mdboom@github-actions
Fix#1417: Fix test for Numpy 2.4.0 (#1418)
1ab529a
* Fix#1417: Fix test for Numpy 2.4.0
* Slightly improve logic
(cherry picked from commit 46470ca)
@github-actions

github-actionsBot commented Jan 13, 2026

Copy link
Copy Markdown

Successfully created backport PR for release/cuda-core-v0.5.1:

@github-actionsgithub-actionsBot mentioned this pull request Jan 13, 2026
Merged
cpcloud pushed a commit that referenced this pull request Jan 13, 2026
@github-actions@mdboom
Fix#1417: Fix test for Numpy 2.4.0 (#1418) (#1476)
e0a11ef
Co-authored-by: Michael Droettboom <mdboom@gmail.com>
Fix#1417: Fix test for Numpy 2.4.0
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leofangleofangleofang approved these changes

Assignees

@mdboommdboom

Labels

cuda.coreEverything related to the cuda.core moduleP0High priority - Must do!testImprovements or additions to tests

Projects

None yet

Milestone

cuda.core v0.6.0

Development

Successfully merging this pull request may close these issues.

[BUG]: Numpy 2.4.0 breaks 6 cuda.core tests

2 participants

@mdboom@leofang