Skip to content

Fix slow test_patterngen_seeds on Windows by sampling - #1461

Merged
Andy-Jost merged 2 commits into
NVIDIA:mainfrom
Andy-Jost:fix-slow-patterngen-test
Jan 13, 2026
Merged

Fix slow test_patterngen_seeds on Windows by sampling#1461
Andy-Jost merged 2 commits into
NVIDIA:mainfrom
Andy-Jost:fix-slow-patterngen-test

Conversation

@Andy-Jost

@Andy-JostAndy-Jost commented Jan 12, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Replace exhaustive O(n²) pairwise seed testing with prime-stride sampling
  • Reduces iterations from ~32,640 to ~100-150 while maintaining meaningful coverage
  • Removes the Windows skip marker added in Add skipifIS_WINDOWS for test_patterngen_seeds #1456, re-enabling the test on Windows

Closes#1455

@Andy-JostAndy-Jost added bug Something isn't working cuda.core Everything related to the cuda.core module labels Jan 12, 2026
@Andy-JostAndy-Jost self-assigned this Jan 12, 2026
@Andy-Jost
Andy-Jost requested a review from rwgkJanuary 12, 2026 18:36
@copy-pr-bot

copy-pr-botBot commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Andy-Jost

Andy-Jost commented Jan 12, 2026

Copy link
Copy Markdown
ContributorAuthor

/ok to test c48274e97305a4fc01080184a38cca3756dc82a9

Andy-Jost
Andy-Jost commented Jan 12, 2026
View reviewed changes
Comment threadcuda_core/tests/test_helpers.py
@@ -47,10 +47,6 @@ def test_latchkernel():
log("done")


@pytest.mark.skipif(

@Andy-JostAndy-JostJan 12, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could leave this in if we want to continue skipping this test on Windows. It is not important to test this on every platform IMO.

@rwgkrwgkJan 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 100% for removing this.

@Andy-Jost

Andy-Jost commented Jan 12, 2026

Copy link
Copy Markdown
ContributorAuthor

The test runs in 0.19s on Linux.

@github-actions

This comment has been minimized.

Sign in to view
rwgk
rwgk reviewed Jan 12, 2026
View reviewed changes
Comment threadcuda_core/tests/test_helpers.py
@@ -47,10 +47,6 @@ def test_latchkernel():
log("done")


@pytest.mark.skipif(

@rwgkrwgkJan 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 100% for removing this.

Comment threadcuda_core/tests/test_helpers.py Outdated
pgen = PatternGen(device, NBYTES)
for i in range(256):
for i in range(0, 256, 17):

@rwgkrwgkJan 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't covering the usual trouble-maker corner case 1 anymore.

This would sample around the usual suspects (0, 1 corner case, then a couple around powers of 2):

(0, 1, 2, 3, 4, 5, 31, 32, 33, 127, 128, 129)

@Andy-JostAndy-JostJan 12, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I included values <5 since those are the most common. I don't think there's anything special about powers of two in this case.

@Andy-Jost
Fix slow test_patterngen_seeds on Windows by sampling
d39f754
Replace exhaustive O(n²) pairwise seed testing with prime-stride
sampling, reducing iterations from ~32k to ~100 while maintaining
meaningful coverage.
ClosesNVIDIA#1455
@Andy-Jost
Andy-Jostforce-pushed the fix-slow-patterngen-test branch from c48274e to d39f754CompareJanuary 12, 2026 19:09
@Andy-Jost

Andy-Jost commented Jan 12, 2026

Copy link
Copy Markdown
ContributorAuthor

/ok to test d39f754

rwgk
rwgk approved these changes Jan 12, 2026
View reviewed changes

@rwgkrwgk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks nice!

>>> n = 0
>>> for i in (ii for ii in range(0, 256) if ii < 5 or ii % 17 == 0):
... js = tuple(jj for jj in range(i + 1, 256) if jj < 5 or jj % 19 == 0)
... print(i, js)
... n += len(js)
...
0 (1, 2, 3, 4, 19, 38, 57, 76, 95, 114, 133, 152, 171, 190, 209, 228, 247)
1 (2, 3, 4, 19, 38, 57, 76, 95, 114, 133, 152, 171, 190, 209, 228, 247)
2 (3, 4, 19, 38, 57, 76, 95, 114, 133, 152, 171, 190, 209, 228, 247)
3 (4, 19, 38, 57, 76, 95, 114, 133, 152, 171, 190, 209, 228, 247)
4 (19, 38, 57, 76, 95, 114, 133, 152, 171, 190, 209, 228, 247)
17 (19, 38, 57, 76, 95, 114, 133, 152, 171, 190, 209, 228, 247)
34 (38, 57, 76, 95, 114, 133, 152, 171, 190, 209, 228, 247)
51 (57, 76, 95, 114, 133, 152, 171, 190, 209, 228, 247)
68 (76, 95, 114, 133, 152, 171, 190, 209, 228, 247)
85 (95, 114, 133, 152, 171, 190, 209, 228, 247)
102 (114, 133, 152, 171, 190, 209, 228, 247)
119 (133, 152, 171, 190, 209, 228, 247)
136 (152, 171, 190, 209, 228, 247)
153 (171, 190, 209, 228, 247)
170 (171, 190, 209, 228, 247)
187 (190, 209, 228, 247)
204 (209, 228, 247)
221 (228, 247)
238 (247,)
255 ()
>>> print(n)
171

@Andy-Jost

Andy-Jost commented Jan 12, 2026

Copy link
Copy Markdown
ContributorAuthor

/ok to test a4dcee1

@Andy-Jost

Andy-Jost commented Jan 12, 2026

Copy link
Copy Markdown
ContributorAuthor

/ok to test d0454f2

@Andy-Jost
Andy-Jostforce-pushed the fix-slow-patterngen-test branch from d0454f2 to f428279CompareJanuary 13, 2026 19:58
@Andy-Jost
Andy-Jost enabled auto-merge (squash) January 13, 2026 19:58
@Andy-Jost

Andy-Jost commented Jan 13, 2026

Copy link
Copy Markdown
ContributorAuthor

/ok to test f428279

@Andy-Jost
Andy-Jost merged commit 8f9f7b5 into NVIDIA:mainJan 13, 2026
80 checks passed
@github-actions

github-actionsBot commented Jan 13, 2026

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

@Andy-Jost
Andy-Jost deleted the fix-slow-patterngen-test branch January 14, 2026 00:01
@leofangleofang added this to the cuda.core beta 12 milestone Jan 14, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwgkrwgkrwgk approved these changes

Assignees

@Andy-JostAndy-Jost

Labels

bugSomething isn't workingcuda.coreEverything related to the cuda.core module

Projects

None yet

Milestone

cuda.core v0.6.0

Development

Successfully merging this pull request may close these issues.

[BUG]: Extremely slow cuda_core/tests/test_helpers.py::test_patterngen_seeds on Windows

3 participants

@Andy-Jost@rwgk@leofang