Skip to content

Add Python bindings for nvJitLink - #157

Merged
leofang merged 37 commits into
mainfrom
ksimpson/add_nvJitLink_bindings
Oct 25, 2024
Merged

Add Python bindings for nvJitLink #157
leofang merged 37 commits into
mainfrom
ksimpson/add_nvJitLink_bindings

Conversation

@keenan-simpson

@keenan-simpsonkeenan-simpson commented Oct 10, 2024•
edited by leofang
Loading

Copy link
Copy Markdown
Contributor

Close#98.

@copy-pr-bot

copy-pr-botBot commented Oct 10, 2024

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang
leofang self-requested a review October 11, 2024 00:49
@leofangleofang added P0 High priority - Must do! feature New feature or request cuda.bindings Everything related to the cuda.bindings module labels Oct 11, 2024
@leofangleofang added this to the cuda.core beta 1 milestone Oct 11, 2024
@leofangleofang linked an issue Oct 11, 2024 that may be closed by this pull request
Add nvjitlink bindings #98
Closed
@leofangleofang changed the title naive approach to adding bindingsAdd Python bindings for nvJitLink Oct 15, 2024
leofang
leofang requested changes Oct 21, 2024
View reviewed changes
Comment threadcuda_bindings/cuda/bindings/_internal/nvjitlink.pyx Outdated
Comment threadcuda_bindings/test_file.cubin Outdated
Comment threadcuda_bindings/tests/test_file.cubin Outdated
Comment threadcuda_bindings/tests/test_nvjitlink.py Outdated
Comment threadcuda_bindings/tests/test_nvjitlink.py Outdated
@keenan-simpson
keenan-simpsonforce-pushed the ksimpson/add_nvJitLink_bindings branch from 979cd14 to cb6c5b4CompareOctober 22, 2024 00:54
@leofang
leofang marked this pull request as ready for review October 22, 2024 18:31
leofang
leofang previously approved these changes Oct 22, 2024
View reviewed changes
Comment threadcuda_bindings/tests/test_nvjitlink.py
Comment threadcuda_bindings/tests/test_nvjitlink.py Outdated
@leofang

leofang commented Oct 22, 2024

Copy link
Copy Markdown
Member

cc @vzhurba01 for vis (in case you have time to take a look)

leofang
leofang reviewed Oct 23, 2024
View reviewed changes
Comment threadcuda_bindings/tests/test_nvjitlink.py Outdated
leofang
leofang previously approved these changes Oct 23, 2024
View reviewed changes
vzhurba01
vzhurba01 reviewed Oct 23, 2024
View reviewed changes
Comment threadcuda_bindings/setup.py Outdated
leofang
leofang reviewed Oct 25, 2024
View reviewed changes
Comment threadcuda_bindings/setup.py Outdated
@leofang

leofang commented Oct 25, 2024

Copy link
Copy Markdown
Member

One note: The added bindings do not need to be backported to the cuda-11 branch, as nvJitLink does not exist until CUDA 12.

@leofang
leofang merged commit f1bfaf0 into mainOct 25, 2024
@leofang
leofang deleted the ksimpson/add_nvJitLink_bindings branch October 25, 2024 16:43
@leofang

leofang commented Oct 25, 2024

Copy link
Copy Markdown
Member

Thanks for working on this & congrats to your first PR merge, @ksimpson-work!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leofangleofangleofang approved these changes
+1 more reviewer
@vzhurba01vzhurba01vzhurba01 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@keenan-simpsonkeenan-simpson

Labels

cuda.bindingsEverything related to the cuda.bindings modulefeatureNew feature or requestP0High priority - Must do!

Projects

None yet

Milestone

cuda.core beta 1

Development

Successfully merging this pull request may close these issues.

Add nvjitlink bindings

3 participants

@keenan-simpson@leofang@vzhurba01