Skip to content

Fix NVRTC error handling - #173

Merged
leofang merged 1 commit into
NVIDIA:mainfrom
leofang:fix_nvrtc
Oct 18, 2024
Merged

Fix NVRTC error handling#173
leofang merged 1 commit into
NVIDIA:mainfrom
leofang:fix_nvrtc

Conversation

@leofang

@leofangleofang commented Oct 16, 2024

Copy link
Copy Markdown
Member

Close#142.

  • We always pass the NVRTC handle to handle_return() except when creating/destroying the handle
  • We form the error message in 2 steps, and the first step does not need any NVRTC handle

@copy-pr-bot

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofangleofang self-assigned this Oct 16, 2024
@leofangleofang added bug Something isn't working P0 High priority - Must do! cuda.core Everything related to the cuda.core module labels Oct 16, 2024
@leofangleofang added this to the cuda.core beta 1 milestone Oct 16, 2024
@leofang
leofang marked this pull request as ready for review October 16, 2024 00:33
@leofang

Copy link
Copy Markdown
MemberAuthor

/ok to test

(curious what would happen...)

@leofang

Copy link
Copy Markdown
MemberAuthor

/ok to test

@leofang
leofang merged commit a860436 into NVIDIA:mainOct 18, 2024
@leofang
leofang deleted the fix_nvrtc branch October 18, 2024 21:31
mdboom pushed a commit to mdboom/cuda-python that referenced this pull request Nov 4, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't workingcuda.coreEverything related to the cuda.core moduleP0High priority - Must do!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix handle_return for NVRTC

1 participant

@leofang