Uh oh!
There was an error while loading. Please reload this page.
Try running without root - #1833
Closed
mdboom wants to merge 1 commit into
Closed
Conversation
Contributor
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
mdboom
commented
Mar 30, 2026
ContributorAuthor
/ok to test |
|
cpcloud
approved these changes
Mar 30, 2026
cpcloud
commented
Apr 7, 2026
Contributor
Is this PR waiting on something? |
mdboom
commented
Apr 9, 2026
ContributorAuthor
No, I think I learned what I wanted to. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The discussion around #1829 got some of us to wondering /why/ the Linux container runs as root with wide-open security.
This line seems to have existed from the first time CI was added to this repo, and was brought over from config in the legate project. I didn't trace it beyond the boundaries of this repo.
It seems that removing it, all the tests still pass.
Additionally, it doesn't result in any more tests being skipped by looking at the logs.
I'm not sure I'm comfortable merging this without confirmation from a project "old timer", but I do feel like this is a better solution to the issue in #1829 than turning off a git security feature.