Skip to content

cuda.core: rename HostCallbackNode.callback_fn to callback - #2024

Merged
Andy-Jost merged 2 commits into
mainfrom
rename-callback-fn-1945
May 5, 2026
Merged

cuda.core: rename HostCallbackNode.callback_fn to callback#2024
Andy-Jost merged 2 commits into
mainfrom
rename-callback-fn-1945

Conversation

@Andy-Jost

@Andy-JostAndy-Jost commented May 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Renames HostCallbackNode.callback_fn to callback. This was missed during the earlier change addressing the naming audit (#1945).

Changes

  • HostCallbackNode.callback_fn -> HostCallbackNode.callback (property + docstring entry).
  • Test assertion key in test_graph_definition.py updated.
  • v1.0.0 release note added under "Breaking changes".

@Andy-Jost@cursoragent
cuda.core: rename HostCallbackNode.callback_fn to callback
01f2fde
Drops the redundant `_fn` suffix on the lone property of
`HostCallbackNode`, completing the agreed-upon item from the v1.0.0
naming audit (#1945).
Surface is tiny: one Cython property, its docstring entry, and one
test assertion key.
Co-authored-by: Cursor <cursoragent@cursor.com>
@Andy-JostAndy-Jost added this to the cuda.core v1.0.0 milestone May 5, 2026
@Andy-JostAndy-Jost added enhancement Any code-related improvements P0 High priority - Must do! cuda.core Everything related to the cuda.core module breaking Breaking changes are introduced labels May 5, 2026
@Andy-JostAndy-Jost self-assigned this May 5, 2026
@Andy-Jost
Andy-Jost requested a review from mdboomMay 5, 2026 18:34
mdboom
mdboom approved these changes May 5, 2026
View reviewed changes

@mdboommdboom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Andy-Jost
Andy-Jost enabled auto-merge (squash) May 5, 2026 18:58
@github-actions

github-actionsBot commented May 5, 2026

Copy link
Copy Markdown
Doc Preview CI

🚀 View preview at
https://nvidia.github.io/cuda-python/pr-preview/pr-2024/

https://nvidia.github.io/cuda-python/pr-preview/pr-2024/cuda-core/

https://nvidia.github.io/cuda-python/pr-preview/pr-2024/cuda-bindings/

https://nvidia.github.io/cuda-python/pr-preview/pr-2024/cuda-pathfinder/


Preview will be ready when the GitHub Pages deployment is complete.

@Andy-Jost
Andy-Jost merged commit b280b9d into mainMay 5, 2026
180 of 182 checks passed
@Andy-Jost
Andy-Jost deleted the rename-callback-fn-1945 branch May 5, 2026 19:26
github-actionsBot pushed a commit that referenced this pull request May 6, 2026
cuda-python-bot
Clean up PR preview folders for 3 closed/merged PRs
e8ebacb
Removed preview folders for the following PRs:
- PR #1983
- PR #2006
- PR #2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdboommdboommdboom approved these changes

Assignees

@Andy-JostAndy-Jost

Labels

breakingBreaking changes are introducedcuda.coreEverything related to the cuda.core moduleenhancementAny code-related improvementsP0High priority - Must do!

Projects

None yet

Milestone

cuda.core v1.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Andy-Jost@mdboom