Skip to content

Move enums from typing -> enums - #2037

Closed
mdboom wants to merge 1 commit into
NVIDIA:mainfrom
mdboom:move-enums
Closed

Move enums from typing -> enums#2037
mdboom wants to merge 1 commit into
NVIDIA:mainfrom
mdboom:move-enums

Conversation

@mdboom

@mdboommdboom commented May 6, 2026

Copy link
Copy Markdown
Contributor

As discussed offline, we could instead put all our enums into their own module, rather than in typing.

@mdboommdboom added P0 High priority - Must do! cuda.core Everything related to the cuda.core module breaking Breaking changes are introduced labels May 6, 2026
@mdboommdboom self-assigned this May 6, 2026
@mdboommdboom mentioned this pull request May 6, 2026
Merged
@leofang

leofang commented May 6, 2026

Copy link
Copy Markdown
Member

I don't like it 🥲

@leofang

leofang commented May 6, 2026

Copy link
Copy Markdown
Member

I prefer cuda.core.typing for all-in-one dumpster, including enums.

By the original design this is a non-issue. Instead of allowing passing cuda.core.enum.AddressingMode.HMM we would have limited to only passing "HMM" (a str), and then we would have added cuda.core.typing.AddressingModeType = Literal["HMM", "ATS"]. So by this argument they belong to typing too, not enum. Enum is IMHO an artificial construct and implementation detail.

@github-actions

github-actionsBot commented May 6, 2026

Copy link
Copy Markdown
Doc Preview CI

🚀 View preview at
https://nvidia.github.io/cuda-python/pr-preview/pr-2037/

https://nvidia.github.io/cuda-python/pr-preview/pr-2037/cuda-core/

https://nvidia.github.io/cuda-python/pr-preview/pr-2037/cuda-bindings/

https://nvidia.github.io/cuda-python/pr-preview/pr-2037/cuda-pathfinder/


Preview will be ready when the GitHub Pages deployment is complete.

@mdboommdboom closed this May 6, 2026
github-actionsBot pushed a commit that referenced this pull request May 7, 2026
cuda-python-bot
Clean up PR preview folders for 5 closed/merged PRs
0333154
Removed preview folders for the following PRs:
- PR #1910
- PR #2018
- PR #2031
- PR #2035
- PR #2037
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mdboommdboom

Labels

breakingBreaking changes are introducedcuda.coreEverything related to the cuda.core moduleP0High priority - Must do!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdboom@leofang