Uh oh!
There was an error while loading. Please reload this page.
Patch 12.6.2 - #217
Conversation
Add _internal to package data files
vzhurba01
commented
Nov 6, 2024
Bypassing branch protection since @leofang already +1nd the internal pull request. Merging. |
| setup( | ||
| version=versioneer.get_version(), | ||
| ext_modules=do_cythonize(extensions), | ||
| packages=find_packages(include=["cuda.cuda", "cuda.cuda.*", "cuda.cuda.bindings", "cuda.cuda.bindings._bindings", "cuda.cuda.bindings._lib", "cuda.cuda.bindings._lib.cyruntime", "cuda.cuda.bindings._internal", "tests"]), | ||
| packages=find_packages(include=["cuda", "cuda.*", "cuda.bindings", "cuda.bindings._bindings", "cuda.bindings._lib", "cuda.bindings._lib.cyruntime", "cuda.bindings._internal"]), | ||
| package_data=dict.fromkeys( | ||
| find_packages(include=["cuda.cuda", "cuda.cuda.*", "cuda.cuda.bindings", "cuda.cuda.bindings._bindings", "cuda.cuda.bindings._lib", "cuda.cuda.bindings._lib.cyruntime", "cuda.cuda.bindings._internal", "tests"]), | ||
| find_packages(include=["cuda", "cuda.*", "cuda.bindings", "cuda.bindings._bindings", "cuda.bindings._lib", "cuda.bindings._lib.cyruntime", "cuda.bindings._internal"]), | ||
| ["*.pxd", "*.pyx", "*.py", "*.h", "*.cpp"], | ||
| ), |
There was a problem hiding this comment.
@vzhurba01 I guess I missed this during review -- were these changes needed as part of the hot fix?
In any case, I think this might have to do with the package_data issue that you hit in #215 (comment). I had a similar observation for cuda.core, and the solution was highlighted here: #171 (comment). I think we have two ways:
- Revert the changes in
setup.py(given that it built fine in the previous patch release) - Apply the same treatment in
cuda.corehere.
There was a problem hiding this comment.
(1) isn't quite true. While that build did work, the posted Windows packages for 11.8.4 and 12.6.1 are both missing all the wildcard files.
(2) Thanks for the pointer. I tried an iteration of something similar, but with whatever I tried I couldn't quite get it to stick. It wasn't identical to what you have there, so I'll try again as soon as I get the chance! 🙏
No description provided.