Skip to content

cuda.core: add tests for ObjectCode.from_object - #2193

Merged
lijinf2 merged 15 commits into
NVIDIA:mainfrom
lijinf2:fix_663
Jun 27, 2026
Merged

cuda.core: add tests for ObjectCode.from_object#2193
lijinf2 merged 15 commits into
NVIDIA:mainfrom
lijinf2:fix_663

Conversation

@lijinf2

@lijinf2lijinf2 commented Jun 10, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Part of Issue #663.

Adds tests for ObjectCode.from_object and the
CI plumbing needed to support them.

  • Create cuda_core/tests/test_binaries/saxpy.cu.
  • Build (build-wheel.yml): Compile saxpy.cu to saxpy.o using nvcc, uploaded
    as ${CUDA_CORE_ARTIFACT_NAME}-test-binaries.
  • Test (test-wheel-{linux,windows}.yml): download the artifact into
    cuda_core/tests/test_binaries/.
  • Pytest (test_module.py): new get_saxpy_object fixture reads bytes
    from cuda_core/tests/test_binaries/saxpy.o; two new tests cover the
    bytes and file-path paths of ObjectCode.from_object.
  • Local dev: build saxpy.o with nvcc on demand if available, else
    skip the new tests.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@lijinf2lijinf2 self-assigned this Jun 10, 2026
@copy-pr-bot

copy-pr-botBot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actionsgithub-actionsBot added CI/CD CI/CD infrastructure cuda.core Everything related to the cuda.core module labels Jun 10, 2026
@lijinf2lijinf2 changed the title Testing CI for fixing 663Testing CI for fixing 663 ObjectCode.from_blockJun 10, 2026
@lijinf2lijinf2 added this to the cuda.core next milestone Jun 10, 2026
@lijinf2

lijinf2 commented Jun 10, 2026

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@copy-pr-bot

copy-pr-botBot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

/ok to test

@lijinf2, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@lijinf2lijinf2 added the test Improvements or additions to tests label Jun 10, 2026
@lijinf2

lijinf2 commented Jun 10, 2026

Copy link
Copy Markdown
ContributorAuthor

/ok to test bbfbbdf98e28edbcd046f9a6c4962ea44668fcd1

@github-actions

This comment has been minimized.

Sign in to view
@lijinf2

lijinf2 commented Jun 11, 2026

Copy link
Copy Markdown
ContributorAuthor

/ok to test 44a490e6e331e456628901ffc1bf16f25b6e7909

@lijinf2lijinf2 changed the title Testing CI for fixing 663 ObjectCode.from_blockcuda.core: add tests for ObjectCode.from_objectJun 11, 2026
isVoid
isVoid reviewed Jun 11, 2026
View reviewed changes
Comment threadcuda_core/tests/test_binaries/saxpy.cu Outdated
isVoid
isVoid reviewed Jun 11, 2026
View reviewed changes
Comment threadcuda_core/tests/test_module.py Outdated
leofang
leofang reviewed Jun 11, 2026
View reviewed changes
Comment threadcuda_core/tests/test_module.py Outdated
@leofang

leofang commented Jun 11, 2026

Copy link
Copy Markdown
Member

Need to merge with the latest main to fix CI.

@leofangleofang added the P0 High priority - Must do! label Jun 11, 2026
@lijinf2

lijinf2 commented Jun 12, 2026

Copy link
Copy Markdown
ContributorAuthor

/ok to test a36588b446caa60427a56106ff9ca0d688b9d547

@lijinf2

lijinf2 commented Jun 15, 2026

Copy link
Copy Markdown
ContributorAuthor

/ok to test 7d16a6475d2d6e6d027275c3f177e498f111750c

@leofang

leofang commented Jun 15, 2026

Copy link
Copy Markdown
Member

/ok to test 1e0580d

leofang
leofang reviewed Jun 15, 2026
View reviewed changes
Comment threadcuda_core/tests/test_module.py
leofang
leofang reviewed Jun 15, 2026
View reviewed changes
Comment threadcuda_core/tests/test_module.py Outdated
leofang
leofang reviewed Jun 15, 2026
View reviewed changes
Comment threadcuda_core/tests/test_module.py Outdated
leofang
leofang reviewed Jun 15, 2026
View reviewed changes
Comment threadcuda_core/tests/test_module.py Outdated
@lijinf2

lijinf2 commented Jun 15, 2026

Copy link
Copy Markdown
ContributorAuthor

/ok to test 4575865

@lijinf2

lijinf2 commented Jun 15, 2026

Copy link
Copy Markdown
ContributorAuthor

/ok to test e2ad6c1

@lijinf2

lijinf2 commented Jun 16, 2026

Copy link
Copy Markdown
ContributorAuthor

/ok to test c224dfc

lijinf2and others added 14 commits June 26, 2026 17:24
@lijinf2

lijinf2 commented Jun 26, 2026

Copy link
Copy Markdown
ContributorAuthor

/ok to test b06b5be6faa396c2414b74ecaff98cc20caa56b8

1 similar comment
@lijinf2

lijinf2 commented Jun 26, 2026

Copy link
Copy Markdown
ContributorAuthor

/ok to test b06b5be6faa396c2414b74ecaff98cc20caa56b8

@lijinf2

lijinf2 commented Jun 26, 2026

Copy link
Copy Markdown
ContributorAuthor

/ok to test 421f8c734b8e040fa842d5204f3624dbca8df4e5

@lijinf2

lijinf2 commented Jun 26, 2026

Copy link
Copy Markdown
ContributorAuthor

/ok to test 463aa4b

@lijinf2
lijinf2 merged commit 875f192 into NVIDIA:mainJun 27, 2026
200 of 202 checks passed
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

github-actionsBot commented Jun 27, 2026

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

@lijinf2lijinf2 mentioned this pull request Jun 30, 2026
Merged
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isVoidisVoidisVoid left review comments
@leofangleofangleofang approved these changes

Assignees

@lijinf2lijinf2

Labels

CI/CDCI/CD infrastructurecuda.coreEverything related to the cuda.core moduleP0High priority - Must do!testImprovements or additions to tests

Projects

None yet

Milestone

cuda.core v1.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@lijinf2@leofang@isVoid