Skip to content

Move release CI tools tests to nightly - #2279

Merged
leofang merged 2 commits into
NVIDIA:mainfrom
lijinf2:fix_2174_b
Jul 2, 2026
Merged

Move release CI tools tests to nightly#2279
leofang merged 2 commits into
NVIDIA:mainfrom
lijinf2:fix_2174_b

Conversation

@lijinf2

@lijinf2lijinf2 commented Jun 29, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

closes#2174

Move ci/tools/tests/ out of the pre-merge test path and into nightly CI so release-time helpers (notably check_release_notes.py, used by release.yml) are exercised regularly without adding meta-tests to every PR.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@lijinf2lijinf2 self-assigned this Jun 29, 2026
@copy-pr-bot

copy-pr-botBot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actionsgithub-actionsBot added the CI/CD CI/CD infrastructure label Jun 29, 2026
@lijinf2lijinf2 added the test Improvements or additions to tests label Jun 29, 2026
@lijinf2lijinf2 added this to the cuda.core v1.1.0 milestone Jun 29, 2026
@lijinf2

lijinf2 commented Jun 29, 2026

Copy link
Copy Markdown
ContributorAuthor

/ok to test d51e0dd79560fbdadbb89e6d10c3d29458a28a4a

@github-actions

This comment has been minimized.

Sign in to view
@leofang

leofang commented Jun 30, 2026

Copy link
Copy Markdown
Member

If you apply this commit d29bc34 you can test the nightly CI in this PR to observe the effect, once it's green we can revert/merge.

@lijinf2

lijinf2 commented Jul 1, 2026

Copy link
Copy Markdown
ContributorAuthor

/ok to test 24780b0

@copy-pr-bot

copy-pr-botBot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

/ok to test 24780b0

@lijinf2, there was an error processing your request: E2

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/

@lijinf2

lijinf2 commented Jul 1, 2026

Copy link
Copy Markdown
ContributorAuthor

/ok to test b712ef4

@lijinf2

lijinf2 commented Jul 1, 2026

Copy link
Copy Markdown
ContributorAuthor

/ok to test b712ef4

@copy-pr-bot

copy-pr-botBot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

/ok to test b712ef4

@lijinf2, there was an error processing your request: E2

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/

@lijinf2

lijinf2 commented Jul 1, 2026

Copy link
Copy Markdown
ContributorAuthor

/ok to test df299a2

@lijinf2

lijinf2 commented Jul 1, 2026

Copy link
Copy Markdown
ContributorAuthor

/ok to test 58fd95efb4cd52f4db0bca276623b51e5399cb6e

leofang
leofang reviewed Jul 2, 2026
View reviewed changes
Comment thread.github/workflows/ci-nightly.yml

- name: Run CI tools unit tests
run: |
python -m pip install pytest

@leofangleofangJul 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: have you verified that this works? I assume we need to call setup-python first?

@lijinf2lijinf2Jul 2, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I verified it on CI. It shows "Nightly: CI tools for release" job passed.

It looks ubuntu-latest comes with python pre-installed, and setup-python isn't strictly required here. We can add it to keep things consistent if there's a chance. Or let me know if you think we should do it now as a follow-up.

@lijinf2

lijinf2 commented Jul 2, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

If you apply this commit d29bc34 you can test the nightly CI in this PR to observe the effect, once it's green we can revert/merge.

Thanks! Cherry-picking d29bc34 worked — nightly CI and test-ci-tools-for-release both passed as shown here.

It looks manual trigger via Github Actions → CI: Nightly optional-deps → Run workflow on the PR branch works too.

Separate issue: numba 0.66.0 (just released today July 1) started breaking nightly numba-cuda on Windows. This is unrelated to this PR (we only move ci/tools/tests to nightly). Also, Nightly had already passed with the cherry-pick trigger (before numba 0.66.0 release). Could we merge this PR without waiting on the numba-cuda pin/fix?

@leofang

leofang commented Jul 2, 2026

Copy link
Copy Markdown
Member

Thanks, Jinfeng!

Separate issue: numba 0.66.0 (just released today July 1) started breaking nightly numba-cuda on Windows. This is unrelated to this PR (we only move ci/tools/tests to nightly). Also, Nightly had already passed with the cherry-pick trigger (before numba 0.66.0 release). Could we merge this PR without waiting on the numba-cuda pin/fix?

It's OK. We'll fix it in NVIDIA/numba-cuda#905.

@leofang

leofang commented Jul 2, 2026

Copy link
Copy Markdown
Member

Admin-merging.

@leofang
leofang merged commit 8d2d1d2 into NVIDIA:mainJul 2, 2026
4 checks passed
@github-actions

github-actionsBot commented Jul 2, 2026

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leofangleofangleofang approved these changes

Assignees

@lijinf2lijinf2

Labels

CI/CDCI/CD infrastructuretestImprovements or additions to tests

Projects

None yet

Milestone

cuda.core v1.1.0

Development

Successfully merging this pull request may close these issues.

Remove helper scripts and tests not exercised by CI

2 participants

@lijinf2@leofang