Uh oh!
There was an error while loading. Please reload this page.
Use cuda.pathfinder to locate nvcc for object-code fixture - #2284
Merged
rwgk merged 2 commits intoJul 1, 2026
Conversation
Contributor
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
rwgk
commented
Jul 1, 2026
ContributorAuthor
/ok to test |
This comment has been minimized.
This comment has been minimized.
leofang
reviewed
Jul 1, 2026
Comment on lines
+198
to
+199
| env = os.environ.copy() | ||
| env["NVCC"] = nvcc_path |
rwgk
commented
Jul 1, 2026
ContributorAuthor
/ok to test |
rwgk
marked this pull request as ready for review
July 1, 2026 18:15
lijinf2
approved these changes
Jul 1, 2026
lijinf2
left a comment
Contributor
There was a problem hiding this comment.
Good catch. Passing the pathfinder-resolved nvcc through NVCC closes the gap with the shell script's bare nvcc call.
rwgk
enabled auto-merge (squash)
July 1, 2026 18:40
Uh oh!
There was an error while loading. Please reload this page.
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes the cuda.core object-code test fixture in environments where
nvccis available throughcuda.pathfinder, but is not directly onPATH.Previously,
get_saxpy_object()checked whethercuda.pathfindercould locatenvcc, but then invokedbuild_test_binaries.shwithout passing that resolved path through. The shell script still called barenvcc, so the fallback build failed whennvccwas discoverable but not onPATH.This PR:
nvcconce withfind_nvidia_binary_utility("nvcc");build_test_binaries.shthroughNVCC;NVCCtonvcc.