Uh oh!
There was an error while loading. Please reload this page.
[doc-only] docs(core): add 1.1.0 to version switcher - #2314
Merged
Conversation
Add the 1.1.0 entry (and backfill the missing 1.0.2) to cuda_core/docs/nv-versions.json, which drives the docs version switcher. Also remove the legacy cuda_core/docs/versions.json and its copy step in build_docs.sh. The Sphinx switcher (conf.py) reads only nv-versions.json; nothing consumes versions.json, and it had been stale since 0.3.2.
This was referenced Jul 7, 2026
|
leofang
reviewed
Jul 7, 2026
Comment on lines
+10
to
+13
| { | ||
| "version": "1.0.2", | ||
| "url": "https://nvidia.github.io/cuda-python/cuda-core/1.0.2/" | ||
| }, |
ContributorAuthor
There was a problem hiding this comment.
My bad: there was a reference to 1.0.2.dev110+g... in _version.py that threw me off
| make html | ||
| # to support version dropdown menu | ||
| cp ./versions.json build/html |
Member
There was a problem hiding this comment.
I think this is still needed when switching to the older versions that used a different Sphinx theme. When we purge the old docs we can clean this up.
ContributorAuthor
There was a problem hiding this comment.
Reverted — versions.json is restored. Left it in place for the older Sphinx-theme docs.
Per review: restore versions.json and its copy step in build_docs.sh (still consumed by older docs built with the previous Sphinx theme), and drop the 1.0.2 nv-versions.json entry since 1.0.2 has not shipped (no tag, not on PyPI). The PR now only adds the 1.1.0 switcher entry.
Andy-Jost
commented
Jul 7, 2026
ContributorAuthor
This change should be ready to go now |
leofang
approved these changes
Jul 7, 2026
leofang
commented
Jul 7, 2026
Member
Thanks, Andy, let's admin-merge |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepares the
cuda.coredocs version switcher for the v1.1.0 release and removes a legacy file that is no longer consumed. Part of the v1.1.0 release checklist (#2291), item "Update the docs for the new version".Changes
1.1.0entry tocuda_core/docs/nv-versions.json(right afterlatest), following the existing pattern documented in.github/RELEASE-core.md. Also backfill the missing1.0.2entry, which was skipped when 1.0.2 shipped.cuda_core/docs/versions.jsonand itscpstep incuda_core/docs/build_docs.sh. The Sphinx version switcher configured incuda_core/docs/source/conf.pyreads onlynv-versions.json; nothing referencesversions.json, and it had been stale since 0.3.2. Its copy step merely published a dead file intobuild/html.Test Coverage
Docs-only change.
nv-versions.jsonvalidated as well-formed JSON.pre-commit run --all-filespasses.Related Work
Release checklist: #2291