Uh oh!
There was an error while loading. Please reload this page.
Fix #2377: Reorganize the test helpers (where appropriate) to cuda_python_test_helpers - #2384
Merged
Conversation
Contributor
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
mdboom
commented
Jul 17, 2026
ContributorAuthor
/ok to test |
mdboom
commented
Jul 17, 2026
ContributorAuthor
/ok to test |
This comment has been minimized.
This comment has been minimized.
mdboom
commented
Jul 17, 2026
ContributorAuthor
/ok to test |
mdboom
commented
Jul 17, 2026
ContributorAuthor
/ok to test |
mdboom
marked this pull request as ready for review
July 20, 2026 13:12
This was referenced Jul 21, 2026
juenglin
approved these changes
Aug 3, 2026
Uh oh!
There was an error while loading. Please reload this page.
mdboom
enabled auto-merge (squash)
August 3, 2026 20:15
Uh oh!
There was an error while loading. Please reload this page.
|
2 tasks
rwgk
commented
Aug 5, 2026
Contributor
My codex thinks this failure https://github.com/NVIDIA/cuda-python/actions/runs/30987658226/job/92246084554?pr=2509 is due to this PR. See below. Is this already on your radar? |
3 tasks
juenglin
commented
Aug 7, 2026
Contributor
juenglin added a commit
that referenced
this pull request
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves test helpers that are generically useful across the subprojects to
cuda_python_test_helpers. It fixes some corner cases in thesys.pathhack to importcuda_python_test_helpers. It doesn't install it as a proper package -- I had hoped that would be possible, but upstreampipdoes not supportpathdependencies in a dependency group. Using that would requirepipto be improved or require everyone to useuv.