Uh oh!
There was an error while loading. Please reload this page.
fix(cuda.core): surface real CUDA error in Device.set_current() - #2461
Merged
Conversation
Contributor
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This comment has been minimized.
This comment has been minimized.
kkraus14
approved these changes
Jul 31, 2026
kkraus14
commented
Jul 31, 2026
Collaborator
@juenglin fix looks good, but is there a reasonable way to test this? |
juenglin
commented
Jul 31, 2026
ContributorAuthor
I couldn't find a way to test it with an automated test. To test it I reproduced the bug with a temporary code change by which get_primary_context would always fail (setting a CUDA error). Then I confirmed that this change fixes it. |
Uh oh!
There was an error while loading. Please reload this page.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes#2460
Device.set_current() raised a misleading ValueError ("Cannot set NULL
context as current") when cuDevicePrimaryCtxRetain failed, discarding
the actual driver error code and leaving the thread-local error state
polluted.
Replace with HANDLE_RETURN(get_last_error()) to raise CUDAError with
the real driver status, matching the established pattern used elsewhere.
Manually verified by patching get_primary_context to return a failure;
a regression test is not practical because the failure requires
exclusive compute mode (unavailable on WDDM) or hardware error states
that cannot be simulated from Python.