Skip to content

Remove tests involving NVLINK_MAX_LINKS#2483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rwgk merged 2 commits into from
Aug 4, 2026
+0 −26
Merged

Remove tests involving NVLINK_MAX_LINKS #2483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcc1c90
Remove tests involving NVLINK_MAX_LINKS
mdboom Aug 3, 2026
dcb56ec
Merge branch 'main' into nvbug6084457-2
mdboom Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions cuda_bindings/tests/nvml/test_nvlink.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,8 +27,3 @@ def test_nvlink_get_link_count(all_devices):
assert value.nvml_return == nvml.Return.SUCCESS or value.nvml_return == nvml.Return.ERROR_NOT_SUPPORTED, (
f"Unexpected return {value.nvml_return} for link count field query"
)

# The feature_nvlink_supported detection is not robust, so we
# can't be more specific about how many links we should find.
if value.nvml_return == nvml.Return.SUCCESS:
assert value.value.ui_val[0] <= nvml.NVLINK_MAX_LINKS, f"Unexpected link count {value.value.ui_val[0]}"
21 changes: 0 additions & 21 deletions cuda_bindings/tests/nvml/test_pynvml.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -265,27 +265,6 @@ def test_device_get_pcie_throughput(ngpus, handles):
# Test pynvml.nvmlDeviceGetNvLinkRemotePciInfo


@pytest.mark.parametrize(
"cap_type",
[
nvml.NvLinkCapability.NVLINK_CAP_P2P_SUPPORTED, # P2P over NVLink is supported
nvml.NvLinkCapability.NVLINK_CAP_SYSMEM_ACCESS, # Access to system memory is supported
nvml.NvLinkCapability.NVLINK_CAP_P2P_ATOMICS, # P2P atomics are supported
nvml.NvLinkCapability.NVLINK_CAP_SYSMEM_ATOMICS, # System memory atomics are supported
nvml.NvLinkCapability.NVLINK_CAP_SLI_BRIDGE, # SLI is supported over this link
nvml.NvLinkCapability.NVLINK_CAP_VALID,
],
) # Link is supported on this device
def test_device_get_nvlink_capability(ngpus, handles, cap_type):
for i in range(ngpus):
for j in range(nvml.NVLINK_MAX_LINKS):
# By the documentation, this should be supported on PASCAL or newer,
# but this also seems to fail on newer.
with unsupported_before(handles[i], None):
cap = nvml.device_get_nvlink_capability(handles[i], j, cap_type)
assert cap >= 0


# Test pynvml.nvmlDeviceResetNvLinkUtilizationCounter
# Test pynvml.nvmlDeviceSetNvLinkUtilizationControl
# Test pynvml.nvmlDeviceGetNvLinkUtilizationCounter
Expand Down
Loading