Uh oh!
There was an error while loading. Please reload this page.
feat(security): onboard security-suite (secret + CodeQL) scanning. - #2589
Conversation
This comment has been minimized.
This comment has been minimized.
Call the centrally maintained NVIDIA/security-workflows security suite rather than wiring each scan separately: one pinned reference runs the Pulse secret scan and CodeQL SAST, both explicitly enabled. Replace .github/workflows/codeql.yml with the suite's SAST scan. Both publish code scanning results under the category /language:python, so keeping the local workflow would put two analyses on every commit that overwrite each other's alerts. The suite performs the same analysis: python, build-mode none, security-extended queries, on ubuntu-latest.
4c4cacf to
c79213cComparegmanal
commented
Aug 11, 2026
@mdboom@rparolin@kkraus14@leofang@jrhemstad — this replaces #2405, which I'm closing. Re-requesting your eyes here since I can't move the review requests across. What is the same as #2405 (already approved by @mdboom and @rparolin): the What is new here:
@kkraus14 — your Git Bash question on #2405 is resolved. The hook moved to v0.3.0 also fixes a false positive worth knowing about: TruffleHog's Lob detector treats |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
|
Description
Onboard NVIDIA security scanning to cuda-python using the centrally maintained NVIDIA/security-workflows surfaces. This uses the security suite — a single pinned reusable workflow that fans out to the individual scanners — rather than one caller per scan. Two complementary controls:
secret-scan-trufflehogpre-commit hook — catches credentials before commit.Every scan in the suite is opt-in, so this repository runs exactly the two scans named here; scanners added upstream later will not switch on by themselves.
Changes
.github/workflows/security-suite.ymlcalling the centralized security suite, onmain,ctk-next, and copy-pr-botpull-request/*branches; the secret scan runs onnv-cpu-general(onboarded for this repo in the enterprise runner config) via thelinux-amd64-cpu4label.enable-secret-scan: trueandenable-sast-scan: true— so what runs here is visible in this file rather than inherited from upstream defaults..github/workflows/codeql.yml, superseded by the suite's SAST scan. Both publish code scanning results under the category/language:python, so running them together would put two analyses on every commit that overwrite each other's alerts. The suite performs the same analysis:python,build-mode: none,security-extendedqueries, onubuntu-latest.secret-scan-trufflehogpre-commit hook (pinned tosecurity-workflowsv0.3.0), skipped on hosted pre-commit.ci which lacks the trufflehog binary.secret-failure-policy: unverifiedexplicitly (fail on verified/live secrets, warn on unverified); fails closed on scanner/infra errors.Checklist