Skip to content

Add cluster to LaunchConfig to support thread block clusters on Hopper - #261

Merged
leofang merged 13 commits into
NVIDIA:mainfrom
leofang:cluster
Dec 13, 2024
Merged

Add cluster to LaunchConfig to support thread block clusters on Hopper#261
leofang merged 13 commits into
NVIDIA:mainfrom
leofang:cluster

Conversation

@leofang

@leofangleofang commented Dec 3, 2024

Copy link
Copy Markdown
Member

Close#204.

@leofangleofang added enhancement Any code-related improvements P1 Medium priority - Should do cuda.core Everything related to the cuda.core module labels Dec 3, 2024
@leofangleofang added this to the cuda.core beta 2 milestone Dec 3, 2024
@leofangleofang self-assigned this Dec 3, 2024
@copy-pr-bot

copy-pr-botBot commented Dec 3, 2024

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang

leofang commented Dec 3, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

(Merge after #247; only commits starting 5d253f1 are new.)

leofang
leofang commented Dec 3, 2024
View reviewed changes
Comment threadcuda_core/cuda/core/experimental/_launcher.py Outdated
leofang
leofang commented Dec 4, 2024
View reviewed changes
Comment threadcuda_core/tests/example_tests/utils.py
@leofang
leofang marked this pull request as ready for review December 4, 2024 03:23
@leofangleofang mentioned this pull request Dec 4, 2024
Merged
@leofangleofang mentioned this pull request Dec 8, 2024
Merged
@leofang

leofang commented Dec 8, 2024

Copy link
Copy Markdown
MemberAuthor

/ok to test

@leofang

leofang commented Dec 8, 2024

Copy link
Copy Markdown
MemberAuthor

@vzhurba01 this is ready for review

keenan-simpson
keenan-simpson reviewed Dec 12, 2024
View reviewed changes
Comment threadcuda_core/cuda/core/experimental/_launcher.py Outdated
keenan-simpson
keenan-simpson reviewed Dec 12, 2024
View reviewed changes
Comment threadcuda_core/examples/thread_block_cluster.py Outdated
keenan-simpson
keenan-simpson reviewed Dec 12, 2024
View reviewed changes

@keenan-simpsonkeenan-simpson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit / comment about the documentation, but otherwise lgtm

@leofang

leofang commented Dec 13, 2024

Copy link
Copy Markdown
MemberAuthor

@ksimpson-work could you help make the changes and get this merged? 🙂

vzhurba01
vzhurba01 reviewed Dec 13, 2024
View reviewed changes
Comment threadcuda_core/docs/source/release/0.1.1-notes.md
vzhurba01
vzhurba01 approved these changes Dec 13, 2024
View reviewed changes

@vzhurba01vzhurba01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keenan-simpson

keenan-simpson commented Dec 13, 2024

Copy link
Copy Markdown
Contributor

/ok to test

@keenan-simpson

keenan-simpson commented Dec 13, 2024

Copy link
Copy Markdown
Contributor

running the tests again for good practice, although the recent commits were only comment changes

@leofang

leofang commented Dec 13, 2024

Copy link
Copy Markdown
MemberAuthor

All green, let's merge. Thanks @ksimpson-work @vzhurba01!

@leofang
leofang merged commit 4ad4042 into NVIDIA:mainDec 13, 2024
@leofang
leofang deleted the cluster branch December 13, 2024 19:39
@leofangleofang mentioned this pull request Dec 17, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@keenan-simpsonkeenan-simpsonkeenan-simpson left review comments
@vzhurba01vzhurba01vzhurba01 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@leofangleofang

@keenan-simpsonkeenan-simpson

Labels

cuda.coreEverything related to the cuda.core moduleenhancementAny code-related improvementsP1Medium priority - Should do

Projects

None yet

Milestone

cuda.core beta 2

Development

Successfully merging this pull request may close these issues.

Support launching thread block clusters

3 participants

@leofang@keenan-simpson@vzhurba01