Skip to content

Add py313 builds - #272

Merged
leofang merged 2 commits into
NVIDIA:mainfrom
leofang:py313
Dec 8, 2024
Merged

Add py313 builds#272
leofang merged 2 commits into
NVIDIA:mainfrom
leofang:py313

Conversation

@leofang

@leofangleofang commented Dec 6, 2024

Copy link
Copy Markdown
Member

Blocked by #267.

xref: #131 (comment)

@leofangleofang added P0 High priority - Must do! CI/CD CI/CD infrastructure labels Dec 6, 2024
@copy-pr-bot

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang

Copy link
Copy Markdown
MemberAuthor

/ok to test

@leofang

Copy link
Copy Markdown
MemberAuthor

Looks like everything builds fine (after a few retries, due to #271).

@leofangleofang changed the title WIP: Add py313 buildsAdd py313 buildsDec 6, 2024
@leofang
leofang marked this pull request as ready for review December 6, 2024 21:47
@leofang

Copy link
Copy Markdown
MemberAuthor

/ok to test

@leofang

Copy link
Copy Markdown
MemberAuthor

@ksimpson-work thanks for the earlier suggestion, this PR is now very clean (one-liner, as expected) 🙂

@leofangleofang self-assigned this Dec 6, 2024
@leofangleofang added cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module labels Dec 6, 2024

@keenan-simpsonkeenan-simpson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks !

@leofang
leofang marked this pull request as draft December 8, 2024 05:35
@leofang
leofang marked this pull request as ready for review December 8, 2024 23:47
@leofang

Copy link
Copy Markdown
MemberAuthor

The test CI has been merged (#124). Let's get this actually tested in the CI.

@leofang

Copy link
Copy Markdown
MemberAuthor

/ok to test

@leofang

Copy link
Copy Markdown
MemberAuthor

All is green, let's merge!

@leofang
leofang merged commit 1ff0b3e into NVIDIA:mainDec 8, 2024
@leofang
leofang deleted the py313 branch December 8, 2024 23:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CDCI/CD infrastructurecuda.bindingsEverything related to the cuda.bindings modulecuda.coreEverything related to the cuda.core moduleP0High priority - Must do!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@leofang@keenan-simpson