Uh oh!
There was an error while loading. Please reload this page.
Prepare for wheel release + populate PyPI page information - #296
Merged
Conversation
Contributor
leofang
commented
Dec 13, 2024
MemberAuthor
/ok to test |
1 similar comment
leofang
commented
Dec 13, 2024
MemberAuthor
/ok to test |
leofang
commented
Dec 13, 2024
MemberAuthor
/ok to test |
leofang
marked this pull request as ready for review
December 13, 2024 14:39
leofang
commented
Dec 13, 2024
MemberAuthor
/ok to test |
vzhurba01
approved these changes
Dec 13, 2024
Contributor
There was a problem hiding this comment.
LGTM but I do have a general comment. By having both DESCRIPTION.rst and README.md I feel like we're duplicating some similar documentation and requires us to remember to update both.
I see that the rst version is a simplified to be better suited for a wheel distribution, so I'm ok with this. Just noticing this made me hesitate for a second and I wanted it to be noted.
leofang
commented
Dec 13, 2024
MemberAuthor
Thanks, Vlad. Indeed we're duplicating some of the information. It might take a few iterations to consolidate the two files and have something presentable on both PyPI and GitHub. Let's address this in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close#147.