Skip to content

Explicitly state which extension uses cpp files - #361

Merged
leofang merged 1 commit into
NVIDIA:mainfrom
vzhurba01:resolve-parallel-builds
Jan 8, 2025
Merged

Explicitly state which extension uses cpp files#361
leofang merged 1 commit into
NVIDIA:mainfrom
vzhurba01:resolve-parallel-builds

Conversation

@vzhurba01

@vzhurba01vzhurba01 commented Jan 7, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Since each cpp is only used by a single extension, a simple solution is to expand the regex pattern and specify which extension uses it directly. Both private and utils have limited number of pyx files and therefore this regex expansion doesn't bloat either.

close#271

@vzhurba01vzhurba01 self-assigned this Jan 7, 2025
@copy-pr-bot

copy-pr-botBot commented Jan 7, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@vzhurba01

vzhurba01 commented Jan 7, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@vzhurba01vzhurba01 changed the title Draft: Explicitly state which exntension uses cpp filesExplicitly state which exntension uses cpp filesJan 7, 2025
@vzhurba01
vzhurba01 requested a review from leofangJanuary 7, 2025 20:32
@vzhurba01vzhurba01 changed the title Explicitly state which exntension uses cpp filesExplicitly state which extension uses cpp filesJan 7, 2025
@vzhurba01
Explicitly state which extension uses cpp files
8620a28
Each cpp file is only used by a single extension
@vzhurba01
vzhurba01force-pushed the resolve-parallel-builds branch from 5370db7 to 8620a28CompareJanuary 7, 2025 20:47
@vzhurba01

vzhurba01 commented Jan 7, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@leofang

leofang commented Jan 8, 2025

Copy link
Copy Markdown
Member

Let me rerun the CI one more time and see if we could still trigger the flaky builds.

@leofangleofang closed this Jan 8, 2025
@leofangleofang reopened this Jan 8, 2025
@leofang

leofang commented Jan 8, 2025

Copy link
Copy Markdown
Member

/ok to test

@leofangleofang added bug Something isn't working P0 High priority - Must do! cuda.bindings Everything related to the cuda.bindings module to-be-backported Trigger the bot to raise a backport PR upon merge labels Jan 8, 2025
@leofang

leofang commented Jan 8, 2025

Copy link
Copy Markdown
Member

Seems like it works. Let's merge and keep an eye on it. Thanks, Vlad!

@vzhurba01

vzhurba01 commented Jan 8, 2025

Copy link
Copy Markdown
ContributorAuthor

Looks like all builds passed. Merging. Thanks!

@leofang
leofang merged commit e774b32 into NVIDIA:mainJan 8, 2025
@github-actions

github-actionsBot commented Jan 8, 2025

Copy link
Copy Markdown

Successfully created backport PR for 11.8.x:

@github-actionsgithub-actionsBot mentioned this pull request Jan 8, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leofangleofangleofang approved these changes
@keenan-simpsonkeenan-simpsonAwaiting requested review from keenan-simpson

Assignees

@vzhurba01vzhurba01

Labels

bugSomething isn't workingcuda.bindingsEverything related to the cuda.bindings moduleP0High priority - Must do!to-be-backportedTrigger the bot to raise a backport PR upon merge

Projects

None yet

Milestone

cuda-python 12.8.0 & 11.8.6

Development

Successfully merging this pull request may close these issues.

Building cuda.bindings in parallel might fail non-deterministically

2 participants

@vzhurba01@leofang