Skip to content

CI: Fix fetching the latest commit from the backport branch - #384

Merged
leofang merged 2 commits into
NVIDIA:mainfrom
leofang:fix_last_commit_fetch
Jan 12, 2025
Merged

CI: Fix fetching the latest commit from the backport branch#384
leofang merged 2 commits into
NVIDIA:mainfrom
leofang:fix_last_commit_fetch

Conversation

@leofang

Copy link
Copy Markdown
Member

Turns out #381 was only a partial fix and I should have run the full CI there 😞 This PR replaces it with a better fix to avoid failures seen in the main branch:
https://github.com/NVIDIA/cuda-python/actions/runs/12736445625
where the LATEST_PRIOR_RUN_ID is empty due to the extra quotation added in #381.

@leofangleofang added P0 High priority - Must do! CI/CD CI/CD infrastructure labels Jan 12, 2025
@leofangleofang self-assigned this Jan 12, 2025
@copy-pr-bot

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang

Copy link
Copy Markdown
MemberAuthor

/ok to test

@leofang

Copy link
Copy Markdown
MemberAuthor

Let me add the backport label and admin-merge to test the backport CI. It should leave a comment in this PR to report an error.

@leofangleofang added the to-be-backported Trigger the bot to raise a backport PR upon merge label Jan 12, 2025
@leofang
leofang merged commit c09e914 into NVIDIA:mainJan 12, 2025
@leofang
leofang deleted the fix_last_commit_fetch branch January 12, 2025 22:09
@github-actions

Copy link
Copy Markdown

Backport failed for 11.8.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 11.8.x
git worktree add -d .worktree/backport-384-to-11.8.x origin/11.8.x
cd .worktree/backport-384-to-11.8.x
git switch --create backport-384-to-11.8.x
git cherry-pick -x aa880355e6d31fa2e7a69e7e15f5561c4417d8a9 9bcf9d665bfc047a7e9a764a74ec2e61d29aa01e

@leofangleofang added bug Something isn't working and removed to-be-backported Trigger the bot to raise a backport PR upon merge labels Jan 12, 2025
@github-actions

Copy link
Copy Markdown

Backport failed for 11.8.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 11.8.x
git worktree add -d .worktree/backport-384-to-11.8.x origin/11.8.x
cd .worktree/backport-384-to-11.8.x
git switch --create backport-384-to-11.8.x
git cherry-pick -x aa880355e6d31fa2e7a69e7e15f5561c4417d8a9 9bcf9d665bfc047a7e9a764a74ec2e61d29aa01e

@leofang

Copy link
Copy Markdown
MemberAuthor

This PR replaces it with a better fix to avoid failures seen in the main branch

this is now fixed

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't workingCI/CDCI/CD infrastructureP0High priority - Must do!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@leofang