Skip to content

Update benchmarks and enable them - #407

Merged
leofang merged 3 commits into
NVIDIA:mainfrom
vzhurba01:109-benchmarks
Feb 21, 2025
Merged

Update benchmarks and enable them#407
leofang merged 3 commits into
NVIDIA:mainfrom
vzhurba01:109-benchmarks

Conversation

@vzhurba01

Copy link
Copy Markdown
Contributor

Close#109

@vzhurba01vzhurba01 added bug Something isn't working P2 Low priority - Nice to have cuda.bindings Everything related to the cuda.bindings module labels Jan 16, 2025
@vzhurba01vzhurba01 self-assigned this Jan 16, 2025
@copy-pr-bot

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@vzhurba01

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@leofangleofang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for delay.

As a follow-up we should work out a nightly test plan so that we can run the benchmarks there (#29).



@pytest.fixture
@pytest.fixture(scope="function")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: isn't function already the default? Actually this is interesting because with cuInit I'd assume that this is session-scoped since there's no way to de-init.

@leofang

Copy link
Copy Markdown
Member

/ok to test

@leofang
leofang enabled auto-merge February 19, 2025 22:02
@leofang

Copy link
Copy Markdown
Member

/ok to test

@github-actions

This comment has been minimized.

@leofang
leofang merged commit 02a4178 into NVIDIA:mainFeb 21, 2025
@github-actions

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't workingcuda.bindingsEverything related to the cuda.bindings moduleP2Low priority - Nice to have

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CuPy benchmark is unconditionally skipped

2 participants

@vzhurba01@leofang