Uh oh!
There was an error while loading. Please reload this page.
Expose ObjectCode as public API + prune unnecessary input arguments - #435
Conversation
keenan-simpson
commented
Feb 4, 2025
/ok to test |
keenan-simpson
commented
Feb 5, 2025
/ok to test |
leofang
commented
Feb 16, 2025
/ok to test |
ObjectCode as public API + prune unnecessary input arguments
|
keenan-simpson
commented
Feb 18, 2025
I think we should invest the time to change the design so that ObjectCode only represents cubins, but I think this change can be standalone thanks to the comment about not passing anything but a cubin when directly constructing an ObjectCode. My thought for ptx / ltoir / other IRs is that we add two things: Program.code -> returns the code string (for user and needed by linker ) Linker will need some modifications. Something like: Linker.add_code_object becomes Linker.add_program() - this is to pass IR program |
9f6496f to
87c1571CompareWe discussed the above comment in an offline meeting. Capturing some thoughts:
FWIW I think adding @vzhurba01 since both Keenan and I already touched this PR significantly, please kindly review it. |
leofang
commented
Feb 18, 2025
/ok to test |
Uh oh!
There was an error while loading. Please reload this page.
vzhurba01
commented
Feb 18, 2025
Small test update needed but all else looks good to me |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Vladislav Zhurba <53052066+vzhurba01@users.noreply.github.com>
leofang
commented
Feb 18, 2025
/ok to test |
leofang
commented
Feb 19, 2025
CI is green! |
close#194
close#448
close#450