Skip to content

Add phase 1 of CUDA Graphs support - #455

Merged
leofang merged 27 commits into
NVIDIA:mainfrom
vzhurba01:114-graphs-initial
Jun 10, 2025
Merged

Add phase 1 of CUDA Graphs support#455
leofang merged 27 commits into
NVIDIA:mainfrom
vzhurba01:114-graphs-initial

Conversation

@vzhurba01

@vzhurba01vzhurba01 commented Feb 19, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

closes#114

@vzhurba01vzhurba01 self-assigned this Feb 19, 2025
@copy-pr-bot

copy-pr-botBot commented Feb 19, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@vzhurba01
vzhurba01 marked this pull request as draft February 19, 2025 19:16
@leofang
leofang self-requested a review February 19, 2025 20:19
@leofangleofang added P0 High priority - Must do! feature New feature or request cuda.core Everything related to the cuda.core module triage Needs the team's attention labels Feb 19, 2025
@leofang

leofang commented Feb 21, 2025

Copy link
Copy Markdown
Member

/ok to test

@github-actions

This comment has been minimized.

Sign in to view
@leofangleofang mentioned this pull request Mar 2, 2025
Open
1 task
@leofangleofang added this to the cuda.core beta 4 milestone Mar 5, 2025
@leofangleofang mentioned this pull request Mar 24, 2025
Closed
@vzhurba01
vzhurba01force-pushed the 114-graphs-initial branch 2 times, most recently from a565301 to ce5bf62CompareMay 5, 2025 20:12
@vzhurba01
vzhurba01force-pushed the 114-graphs-initial branch from ce5bf62 to 5e7713aCompareMay 8, 2025 21:35
@vzhurba01vzhurba01 changed the title Draft for graph APIsAdd phase 1 of Graphs supportMay 8, 2025
@vzhurba01vzhurba01 changed the title Add phase 1 of Graphs supportAdd phase 1 of CUDA Graphs supportMay 8, 2025
@vzhurba01

vzhurba01 commented May 8, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test 5e7713a

@vzhurba01

vzhurba01 commented May 8, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test bad5c3e

@vzhurba01
vzhurba01 marked this pull request as ready for review May 8, 2025 22:38
@vzhurba01
vzhurba01force-pushed the 114-graphs-initial branch from 29f8ed8 to 4803dacCompareMay 19, 2025 19:12
@vzhurba01

vzhurba01 commented May 19, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test 4803dac

@vzhurba01

vzhurba01 commented May 19, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test f635a20

@vzhurba01

vzhurba01 commented May 19, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test fa96f48

@vzhurba01

vzhurba01 commented May 19, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test 9bb2b9b

@vzhurba01

vzhurba01 commented May 19, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test b577351

@vzhurba01

vzhurba01 commented May 19, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test 090edcc

@vzhurba01

vzhurba01 commented May 20, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test 6d037dc

@vzhurba01
vzhurba01force-pushed the 114-graphs-initial branch from 6d037dc to 1c41c2aCompareMay 20, 2025 17:37
@vzhurba01

vzhurba01 commented May 20, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test 1c41c2a

@vzhurba01

vzhurba01 commented May 20, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test 27f674c

@leofangleofang removed the triage Needs the team's attention label May 31, 2025
@leofang

leofang commented Jun 7, 2025

Copy link
Copy Markdown
Member

/ok to test de22d5f

leofang
leofang reviewed Jun 9, 2025
View reviewed changes

@leofangleofang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, thanks a lot @vzhurba01 for solid works in design/implementation/testing! I left a few hopefully quick questions mainly on naming of a few things.

Comment threadcuda_core/cuda/core/experimental/_graph.py Outdated
Comment threadcuda_core/cuda/core/experimental/_graph.py Outdated
Comment threadcuda_core/cuda/core/experimental/_graph.py Outdated
Comment threadcuda_core/cuda/core/experimental/_graph.py
Comment threadcuda_core/cuda/core/experimental/_graph.py Outdated
Comment threadcuda_core/tests/test_graph.py
Comment threadcuda_core/tests/test_graph.py Outdated
Comment threadcuda_core/tests/test_graph.py Outdated
Comment threadcuda_core/tests/test_graph.py Outdated
Comment threadcuda_core/cuda/core/experimental/_graph.py Outdated
@leofang

leofang commented Jun 10, 2025

Copy link
Copy Markdown
Member

/ok to test ded7844

leofang
leofang previously approved these changes Jun 10, 2025
View reviewed changes

@leofangleofang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! As discussed offline @vzhurba01 plz take another look (at my changes) when you get a chance.

vzhurba01
vzhurba01 commented Jun 10, 2025
View reviewed changes
Comment threadcuda_core/cuda/core/experimental/_graph.py Outdated
@leofang

leofang commented Jun 10, 2025

Copy link
Copy Markdown
Member

Thanks, Vlad! Since the CI was green and the last change is string-only, let me admin-merge it.

@leofang
leofang merged commit 314060c into NVIDIA:mainJun 10, 2025
@github-actions

github-actionsBot commented Jun 10, 2025

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leofangleofangleofang left review comments

Assignees

@vzhurba01vzhurba01

Labels

cuda.coreEverything related to the cuda.core modulefeatureNew feature or requestP0High priority - Must do!

Projects

None yet

Milestone

cuda.core beta 4

Development

Successfully merging this pull request may close these issues.

Design of graph support - Phase 1

2 participants

@vzhurba01@leofang