Skip to content

Add a Linker example - #475

Merged
leofang merged 7 commits into
NVIDIA:mainfrom
vzhurba01:324-linker-example
Mar 1, 2025
Merged

Add a Linker example#475
leofang merged 7 commits into
NVIDIA:mainfrom
vzhurba01:324-linker-example

Conversation

@vzhurba01

@vzhurba01vzhurba01 commented Feb 26, 2025

Copy link
Copy Markdown
Contributor

close#324

@vzhurba01vzhurba01 added enhancement Any code-related improvements P0 High priority - Must do! cuda.core Everything related to the cuda.core module labels Feb 26, 2025
@vzhurba01vzhurba01 added this to the cuda.core beta 3 milestone Feb 26, 2025
@vzhurba01vzhurba01 self-assigned this Feb 26, 2025
@copy-pr-bot

copy-pr-botBot commented Feb 26, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@vzhurba01vzhurba01 changed the title Add Linker exampleAdd a Linker exampleFeb 26, 2025
@vzhurba01vzhurba01 changed the title Add a Linker exampleAdd a Linker exampleFeb 26, 2025
@vzhurba01vzhurba01 changed the title Add a Linker exampleAdd a Linker exampleFeb 26, 2025
@vzhurba01

vzhurba01 commented Feb 26, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@vzhurba01

vzhurba01 commented Feb 26, 2025

Copy link
Copy Markdown
ContributorAuthor

Here's what python examples/jit_lto_fractal.py -t all -d displays:
hit_lto_fractal_image

@github-actions

This comment has been minimized.

Sign in to view
keenan-simpson
keenan-simpson reviewed Feb 27, 2025
View reviewed changes
Comment threadcuda_core/examples/jit_lto_fractal.py Outdated
keenan-simpson
keenan-simpson reviewed Feb 27, 2025
View reviewed changes

@keenan-simpsonkeenan-simpson left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one little nit, but otherwise it looks good to me. Fractal art engages my monkey brain

keenan-simpson
keenan-simpson reviewed Feb 27, 2025
View reviewed changes
Comment threadcuda_core/examples/jit_lto_fractal.py Outdated
@leofang

leofang commented Feb 27, 2025

Copy link
Copy Markdown
Member

Thanks, Vlad! I have a local patch that uses LTO-IR instead. I will push but I'd like to come up with a way of showing both approaches (linking all PTXs vs linking 1 PTX with LTO-IRs).

@leofang

leofang commented Feb 28, 2025

Copy link
Copy Markdown
Member

/ok to test

@leofang

leofang commented Feb 28, 2025

Copy link
Copy Markdown
Member

CI is green!

rwgk
rwgk reviewed Feb 28, 2025
View reviewed changes
Comment threadcuda_core/examples/jit_lto_fractal.py Outdated
Comment threadcuda_core/examples/jit_lto_fractal.py
Comment threadcuda_core/examples/jit_lto_fractal.py Outdated
Comment threadcuda_core/examples/jit_lto_fractal.py
Comment threadcuda_core/examples/jit_lto_fractal.py Outdated
Comment threadcuda_core/examples/jit_lto_fractal.py Outdated
Comment threadcuda_core/examples/jit_lto_fractal.py Outdated
Comment threadcuda_core/examples/jit_lto_fractal.py Outdated
Comment threadcuda_core/examples/jit_lto_fractal.py Outdated
Comment threadcuda_core/examples/jit_lto_fractal.py
@vzhurba01

vzhurba01 commented Feb 28, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

rwgk
rwgk approved these changes Mar 1, 2025
View reviewed changes
@rwgk

rwgk commented Mar 1, 2025

Copy link
Copy Markdown
Contributor

/ok to test

@leofang
leofang merged commit 03001e5 into NVIDIA:mainMar 1, 2025
@leofang

leofang commented Mar 1, 2025

Copy link
Copy Markdown
Member

Thanks, @vzhurba01@rwgk!

@leofangleofang mentioned this pull request Mar 3, 2025
Merged
@github-actions

github-actionsBot commented Mar 3, 2025

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

@leofang

leofang commented Mar 3, 2025

Copy link
Copy Markdown
Member

Note: the bot cleanup came too late because I noticed the CPU runners were not accessible when merging to main:
https://github.com/NVIDIA/cuda-python/actions/runs/13606001690/attempts/1
and I had to manually trigger a re-run for failed jobs.

@leofangleofang mentioned this pull request Mar 14, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwgkrwgkrwgk approved these changes
@leofangleofangAwaiting requested review from leofang
+1 more reviewer
@keenan-simpsonkeenan-simpsonkeenan-simpson left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@vzhurba01vzhurba01

Labels

cuda.coreEverything related to the cuda.core moduleenhancementAny code-related improvementsP0High priority - Must do!

Projects

None yet

Milestone

cuda.core beta 3

Development

Successfully merging this pull request may close these issues.

Add a Linker example

4 participants

@vzhurba01@leofang@rwgk@keenan-simpson